Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop non-slash commands #68

Open
NyCodeGHG opened this issue May 1, 2021 · 4 comments
Open

Drop non-slash commands #68

NyCodeGHG opened this issue May 1, 2021 · 4 comments

Comments

@NyCodeGHG
Copy link
Member

NyCodeGHG commented May 1, 2021

Announcement 04.08.2021
As of today, we're going to drop support for Message Commands, the reasoning being Discord announcing deprecation for message contents for verified bots and therefore also wanting devs to move on from message commands. BankoBot will continue to allow using message commands as long as neither Discord drops our acccess to the message content or kordx.commands will migrate to being a slash commands lib. However we'll stop accepting Bug Reports for message commands and not consider compatibility with message commands for new features/commands

I think we should drop Support for non slash commands, so we can fully use the new features of discord without having to write 5k lines of Code Just for supporting both variants. When we implement this we have to find a solution for a better experience with some tag commands. Especially those which require multi line arguments.

@DRSchlaubi
Copy link
Contributor

actually a good idea but we need to put it on hold as slash commands lack e.g. multi-line arguments. kordx.commands wants to drop them too so we will do it eventually

@DRSchlaubi DRSchlaubi added the freezer Currently put on hold label May 1, 2021
@NyCodeGHG
Copy link
Member Author

A workaround for multi line arguments would be when you execute the command like:

/edit-tag kotlin

Then the bot asks you for the updated text and you have 5 minutes to send it into the current channel.

@warriorzz
Copy link
Member

Is it possible to use Argument#optional() in slash commands? not sure if we need that, but would be nice for user mentions

@DRSchlaubi
Copy link
Contributor

it is just don't do anything after asSLashArgument

@DRSchlaubi DRSchlaubi removed the freezer Currently put on hold label Feb 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants