Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ feat(date): Possibility to return invalid date #1370

Closed
1 task done
SandraVucko opened this issue Apr 3, 2024 · 3 comments · Fixed by #1384
Closed
1 task done

✨ feat(date): Possibility to return invalid date #1370

SandraVucko opened this issue Apr 3, 2024 · 3 comments · Fixed by #1384
Assignees
@mmarinkov
Labels
✨ feature New feature or request 💬 ux & ds sync Topics for the weekly exchange between UX & DS Devs

Comments

@SandraVucko
Copy link

Question

How can we distinguish in the date picker whether an incorrect date (e.g. 38.15.2024) has been entered or whether no date has been entered? We would like to throw a specific error message in the first case.

Additional Information

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@SandraVucko SandraVucko added the 💬 question Further information is requested label Apr 3, 2024
@hirsch88 hirsch88 changed the title 💬 question(Date): How to recognize invalid date input 💬 question(date): How to recognize invalid date input Apr 10, 2024
@mmarinkov
Copy link
Contributor

  • add new prop to enable component to send invalid dates back
  • add warning hints if invalid date -> check with UX

@mmarinkov mmarinkov changed the title 💬 question(date): How to recognize invalid date input ✨ feat(date): Possibility to return invalid date Apr 18, 2024
@mmarinkov mmarinkov added ✨ feature New feature or request 💬 ux & ds sync Topics for the weekly exchange between UX & DS Devs and removed 💬 question Further information is requested labels Apr 18, 2024
@mmarinkov mmarinkov self-assigned this Apr 18, 2024
@mmarinkov
Copy link
Contributor

/cib

@github-actions GitHub Actions
Copy link
Contributor

Branch feat/issue-1370 created!

github-actions bot added a commit that referenced this issue Apr 18, 2024
@github-actions
Create PR for #1370
680b08a
@github-actions github-actions bot mentioned this issue Apr 18, 2024
Merged
hirsch88 added a commit that referenced this issue May 16, 2024
@github-actions @hirsch88 @yannickholzenkamp
✨ feat(date): Possibility to return invalid date (#1384)
6619ba9 
* Create PR for #1370

* add changeset

* feat(date): add prop allow-invalid-dates

* chore(): rename prop to generic so it can be used for other masks

* chore: export const INVALID_VALUE

* chore: fix formatting

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Gery Hirschfeld <gerhard.hirschfeld@baloise.ch>
Co-authored-by: Yannick Holzenkamp <yannick.holzenkamp@baloise.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mmarinkov mmarinkov

Labels
✨ feature New feature or request 💬 ux & ds sync Topics for the weekly exchange between UX & DS Devs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

✨ feat(date): Possibility to return invalid date baloise/design-system
2 participants
@SandraVucko @mmarinkov