Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Incorrect 'module-info.class' file is packed with the Ballerina executable JAR #42318

Closed
gabilang opened this issue Mar 14, 2024 · 2 comments · Fixed by #42732
Closed

[Bug]: Incorrect 'module-info.class' file is packed with the Ballerina executable JAR #42318

gabilang opened this issue Mar 14, 2024 · 2 comments · Fixed by #42732
Assignees
@Thevakumar-Luheerathan
Labels
Area/ProjectAPI Reason/Other None of the other reasons. Team/DevTools Ballerina Developer Tooling ( CLI, Test FW, Package Management, OpenAPI, APIDocs ) Type/Bug

Comments

@gabilang
Copy link
Contributor

Description

The module-info.class file of the Ballerina executable JAR (found in the jar's root directory) contains the same content of the module-info.java file of the lang.__internal langlib module, which is irrelevant.

module io.ballerina.lang.internal {
   requires io.ballerina.lang;
   requires io.ballerina.runtime;

   exports org.ballerinalang.langlib.internal;
}

Steps to Reproduce

No response

Affected Version(s)

No response

OS, DB, other environment details and versions

No response

Related area

-> Compilation

Related issue(s) (optional)

No response

Suggested label(s) (optional)

No response

Suggested assignee(s) (optional)

No response
@ballerina-bot ballerina-bot added needTriage The issue has to be inspected and labeled manually userCategory/Compilation labels Mar 14, 2024
@gabilang gabilang added Area/ProjectAPI Team/DevTools Ballerina Developer Tooling ( CLI, Test FW, Package Management, OpenAPI, APIDocs ) and removed needTriage The issue has to be inspected and labeled manually userCategory/Compilation labels Mar 14, 2024
@gabilang
Copy link
Contributor Author

The above module-info.class is packed with ballerina-rt.jar as well. It seems that the modular info creation needs to be handled properly.

@gabilang gabilang mentioned this issue Mar 15, 2024
Closed
Merged
13 tasks
@github-actions GitHub Actions
Copy link

This issue is NOT closed with a proper Reason/ label. Make sure to add proper reason label before closing. Please add or leave a comment with the proper reason label now.

      - Reason/EngineeringMistake - The issue occurred due to a mistake made in the past.
      - Reason/Regression - The issue has introduced a regression.
      - Reason/MultipleComponentInteraction - Issue occured due to interactions in multiple components.
      - Reason/Complex - Issue occurred due to complex scenario.
      - Reason/Invalid - Issue is invalid.
      - Reason/Other - None of the above cases.

@azinneera azinneera added the Reason/Other None of the other reasons. label May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Thevakumar-Luheerathan Thevakumar-Luheerathan

Labels
Area/ProjectAPI Reason/Other None of the other reasons. Team/DevTools Ballerina Developer Tooling ( CLI, Test FW, Package Management, OpenAPI, APIDocs ) Type/Bug
Projects
Ballerina Team Main Board
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove module-info.class from final executable Thevakumar-Luheerathan/ballerina-lang
4 participants
@azinneera @ballerina-bot @gabilang @Thevakumar-Luheerathan