Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement]: Implement the getLocation API for the structured type symbols #42725

Closed
nipunayf opened this issue May 9, 2024 · 0 comments · Fixed by #42737
Closed

[Improvement]: Implement the getLocation API for the structured type symbols #42725

nipunayf opened this issue May 9, 2024 · 0 comments · Fixed by #42737
Assignees
Labels
Area/SemanticAPI Semantic API Related Issues #Compiler Team/CompilerFETools Semantic API, Formatter, Shell Type/Improvement
Milestone

Comments

@nipunayf
Copy link
Contributor

nipunayf commented May 9, 2024

Description

Currently, the getLocation invocation for the structured type symbols described in the spec returns an empty value. As these types are defined by the user, it's optimal to override the following method for the respective type symbols.

public Optional<Location> getLocation() {
return Optional.empty();
}

Describe your problem(s)

No response

Describe your solution(s)

If the getLocation implementation is the same across all the respective typeSymbols, we can write an abstract class called StructuredTypeSymbol as the parent class. Otherwise, we may have to override the given values individually.

Related area

-> Compilation

Related issue(s) (optional)

No response

Suggested label(s) (optional)

No response

Suggested assignee(s) (optional)

No response

@nipunayf nipunayf added Type/Improvement Team/CompilerFETools Semantic API, Formatter, Shell Area/SemanticAPI Semantic API Related Issues #Compiler labels May 9, 2024
@nipunayf nipunayf self-assigned this May 9, 2024
@nipunayf nipunayf changed the title [Improvement]: Implement the getLocation API for the structured symbols [Improvement]: Implement the getLocation API for the structured symbols May 9, 2024
@nipunayf nipunayf changed the title [Improvement]: Implement the getLocation API for the structured symbols [Improvement]: Implement the getLocation API for the structured type symbols May 9, 2024
@nipunayf nipunayf added this to the 2201.10.0 milestone May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area/SemanticAPI Semantic API Related Issues #Compiler Team/CompilerFETools Semantic API, Formatter, Shell Type/Improvement
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant