Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GraphQL BBE : Why using underscores? #8647

Closed
anupama-pathirage opened this issue Feb 5, 2024 · 5 comments · Fixed by ballerina-platform/ballerina-distribution#5275
Closed
Assignees
Labels
Reason/Other None of the other reasons. Type/Bug Bugs that need to be fixed.

Comments

@anupama-pathirage
Copy link
Contributor

anupama-pathirage commented Feb 5, 2024

Description

$subject in GraphQL service - Service interceptors and GraphQL service - Field interceptors

image
@anupama-pathirage anupama-pathirage added the Type/Bug Bugs that need to be fixed. label Feb 5, 2024
@ThisaruGuruge
Copy link
Member

This is a rendering bug. Underscores are used to italicize the characters. @sm1990 Any thoughts?

@sm1990 sm1990 assigned sm1990 and unassigned praneesha Mar 27, 2024
@sm1990
Copy link
Contributor

sm1990 commented Mar 28, 2024

@ThisaruGuruge we have used back-ticks on the either sides of the text (https://github.com/ballerina-platform/ballerina-distribution/blob/6e60f543f51fadde4f894f7e965f856debf4ded3/examples/graphql-service-interceptors/graphql_service_interceptors.md?plain=1#L3). Thus the text is rendered as a code instead of an italicized text. I removed the back-ticks and tested it. The following is the output.
output-onlinejpgtools

@ThisaruGuruge
Copy link
Member

@DimuthuMadushan Any idea why we have used backticks here? If it is not necessary, shall we remove them?

@DimuthuMadushan
Copy link
Contributor

It was mistakenly added as a review suggestion. I'll fix this.

Copy link

This issue is NOT closed with a proper Reason/ label. Make sure to add proper reason label before closing. Please add or leave a comment with the proper reason label now.

      - Reason/EngineeringMistake - The issue occurred due to a mistake made in the past.
      - Reason/Regression - The issue has introduced a regression.
      - Reason/MultipleComponentInteraction - Issue occured due to interactions in multiple components.
      - Reason/Complex - Issue occurred due to complex scenario.
      - Reason/Invalid - Issue is invalid.
      - Reason/Other - None of the above cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Reason/Other None of the other reasons. Type/Bug Bugs that need to be fixed.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants