Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to use Vite instead of Create React App #515

Open
wants to merge 25 commits into
base: master
Choose a base branch
from
Open

Migrate to use Vite instead of Create React App #515

wants to merge 25 commits into from

Conversation

thienandangthanh
Copy link

@thienandangthanh thienandangthanh commented Nov 7, 2023 •
edited

Fix #514

What have been done

  • Upgrade to React 17
  • Upgrade packages to latest version, except husky and lint-staged
  • Replace create-react-app with vite
  • The build command, build output stay the same

Reference

@thienandangthanh
Init new vite project
0ebda61
@thienandangthanh
Add rendition 35.1.0
28586e4
@thienandangthanh
Add browserslist-to-esbuild
5a39275
@thienandangthanh
Add browsersListToEsbuild config
bc3a29c
@thienandangthanh
Add styled-components 6.1.0
fa12087
@thienandangthanh
Add whatwg-fetch 3.6.19
c1c517b
@thienandangthanh
Add husky and lint-staged
5a305f0
@thienandangthanh
Add @types/json-schema
3153cb5
@thienandangthanh
Add promise-polyfill
29b5010
@thienandangthanh
Copy src from old ui
69b62f9 
- copy src directory
- move public/index.html to index.html
- remove %PUBLIC_URL%
- add module script to the bottom of the body tag
@thienandangthanh
Use util instead of Node.js util
8036a6e 
Reference: APIDevTools/json-schema-ref-parser#257 (comment)
@thienandangthanh
Add start script to run as old ui
5b2b24e
@thienandangthanh
Set default port to 3000 and auto open browser
68b1165
@thienandangthanh
Remove redundant vite.svg logo
e5e1c30
@thienandangthanh
Use build instead of dist as build output
eddbe99 
Reason: to match create-react-app output
@thienandangthanh
Only output sourcemap in development mode
452e583
@thienandangthanh
Use eslint instead of @balena/lint with lintstaged
5923097
@thienandangthanh
Rename project and version
f91b87b
@thienandangthanh
Downgrade husky to v4, lint-staged to v10
906da30
@thienandangthanh
Replace old ui with new vite ui
8b8b534
@thienandangthanh
Revert README changes
739dd8e
@thienandangthanh
Remove redundant HTML comment
43a5e4f 
Reason: %PUBLIC_URL% is not used with vite
@thienandangthanh
Copy link
Author

thienandangthanh commented Nov 7, 2023 •
edited

I found out there's a problem that the ui only show blank page when running with wifi-connect binary.

The cause is that vite build output both assets and static directory. But wifi-connect doesn't serve the assets folder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Proposal: Replace create-react-app with Vite for Improved UI Development and DX
1 participant
@thienandangthanh