balena push fails when invalid symlink is present even if ignored

[majorz]

Existing invalid symlink inside the project is breaking balena push even if it has been ignored inside .dockerignore file. Affects all balena CLI versions and OS versions this is run on.

Steps to reproduce:

1. Create a minimal application
2. Create an invalid symlink ln -sf non_existing_file invalid_symlink
3. Add invalid_symlink to .dockeignore file
4. balena push the project

The command exits early with:

Packaging the project source...
[Debug]   Tarring all non-ignored files...
No such file or directory: (..)/invalid_symlink
Error: ENOENT: no such file or directory, stat '(..)/invalid_symlink'

It looks like the error originates early in listFiles of lib/utils/ignore.ts and at that point .dockerignore is still not being processed. An easier fix could be to ignore all broken symlinks at that stage by default.

[jellyfish-bot]

[majorz] This has attached https://jel.ly.fish/5c0038d6-997e-42b0-bd52-4115e64dfcd8

[majorz]

Related to #2383, but not exactly the same bug.