Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG mutation of object valuesToSet in update blueprints action #7300

Open
AntoineB05 opened this issue Aug 23, 2023 · 2 comments
Open

BUG mutation of object valuesToSet in update blueprints action #7300

AntoineB05 opened this issue Aug 23, 2023 · 2 comments
Labels
has pr There is an open pull request (in this repo or elsewhere) related to this issue.

Comments

@AntoineB05
Copy link

Node version: v14.20.0
Sails version (sails): v1.5.7
ORM hook version (sails-hook-orm): 4.0.2
Sockets hook version (sails-hook-sockets): 2.0.4
Organics hook version (sails-hook-organics):
Grunt hook version (sails-hook-grunt): 5.0.0
Uploads hook version (sails-hook-uploads):
DB adapter & version (e.g. sails-mysql@5.55.5): sails-mongo: "2.0.1"
Skipper adapter & version (e.g. skipper-s3@5.55.5): 0.6.0


@sailsbot
Copy link

@AntoineB05 Thanks for posting! We'll take a look as soon as possible.

In the mean time, there are a few ways you can help speed things along:

  • look for a workaround. (Even if it's just temporary, sharing your solution can save someone else a lot of time and effort.)
  • tell us why this issue is important to you and your team. What are you trying to accomplish? (Submissions with a little bit of human context tend to be easier to understand and faster to resolve.)
  • make sure you've provided clear instructions on how to reproduce the bug from a clean install.
  • double-check that you've provided all of the requested version and dependency information. (Some of this info might seem irrelevant at first, like which database adapter you're using, but we ask that you include it anyway. Oftentimes an issue is caused by a confluence of unexpected factors, and it can save everybody a ton of time to know all the details up front.)
  • read the code of conduct.
  • if appropriate, ask your business to sponsor your issue. (Open source is our passion, and our core maintainers volunteer many of their nights and weekends working on Sails. But you only get so many nights and weekends in life, and stuff gets done a lot faster when you can work on it during normal daylight hours.)
  • let us know if you are using a 3rd party plugin; whether that's a database adapter, a non-standard view engine, or any other dependency maintained by someone other than our core team. (Besides the name of the 3rd party package, it helps to include the exact version you're using. If you're unsure, check out this list of all the core packages we maintain.)

Please remember: never post in a public forum if you believe you've found a genuine security vulnerability. Instead, disclose it responsibly.

For help with questions about Sails, click here.

@AntoineB05
Copy link
Author

AntoineB05 commented Aug 23, 2023

Hello,
I had a problem with the sending of addedTo and removedTo socket notifications when I updated a record with the default update blueprints action. After an investigation, I found the bug was caused by a mutation of the queryOptions.valuesToSet object after the updateOne fonction. I use mongoDB as database. I just added a cloneDeep to prevent the mutation. After the fix, I receive now the addedTo and removedTo socket notifications. Link to the PR with the fix proposed: #7294
@mikermcneil

@eashaw eashaw added the has pr There is an open pull request (in this repo or elsewhere) related to this issue. label Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has pr There is an open pull request (in this repo or elsewhere) related to this issue.
Development

No branches or pull requests

3 participants