Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate Slither #1941

Open
nventuro opened this issue Oct 24, 2022 · 2 comments
Open

Integrate Slither #1941

nventuro opened this issue Oct 24, 2022 · 2 comments
Assignees

Comments

@nventuro
Copy link
Contributor

We likely don't care much about the base detectors, but can write custom ones that'd be highly useful. E.g. #1940, or checking that past a certain point a contract makes no external calls (which is a useful property to test in e.g. pools).

@jubeira
Copy link
Contributor

jubeira commented Oct 27, 2022

After some research, my preliminary conclusion is that slither doesn't play along very well with monorepos.

In short, when it analyzes contracts that have dependencies outside the contracts' own workspace, it is unable to find them and it halts (see crytic/crytic-compile#279). At the moment I didn't find a way to indicate slither how to find those dependencies.

This can potentially be solved if we could indicate where our root node_modules directory is. I've opened a PR with a potential solution in crytic-compile, which is the dependency that handles that: crytic/crytic-compile#301.

@jubeira
Copy link
Contributor

jubeira commented Nov 25, 2022

Rule to add when we have it: #1940 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants