Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specifying multiple triggers does not behave as expected #1259

Closed
bo0tzz opened this issue May 12, 2024 · 2 comments
Closed

Specifying multiple triggers does not behave as expected #1259

bo0tzz opened this issue May 12, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@bo0tzz
Copy link

bo0tzz commented May 12, 2024

Describe the bug
When specifying multiple triggers on a ReplicationSource, for example

spec:
  trigger:
    schedule: 0 23 * * *
    manual: foo

The schedule trigger gets ignored.

Steps to reproduce
Create an RS with the above triggers

Expected behavior
Either both triggers apply, or the resource is rejected by a webhook when applying.

Actual results
Only the manual trigger applies, and the schedule is ignored.

Additional context
I believe the relevant code that ends up ignoring the schedule trigger is this

func getTrigger(r ReplicationMachine) triggerType {
switch {
case len(r.ManualTag()) > 0:
return manualTrigger
case len(r.Cronspec()) > 0:
return scheduleTrigger
default:
return noTrigger
}
}

@bo0tzz bo0tzz added the bug Something isn't working label May 12, 2024
@tesshuflower
Copy link
Contributor

@bo0tzz VolSync doesn't support using manual and schedule triggers at the same time. If you use a manual trigger and want to go back to your schedule you'll need to remove the manual trigger.

@tesshuflower tesshuflower closed this as not planned Won't fix, can't repro, duplicate, stale May 13, 2024
@bo0tzz
Copy link
Author

bo0tzz commented May 13, 2024

VolSync doesn't support using manual and schedule triggers at the same time

I am aware of that. The issue is that it still lets me set both, and then fails silently. I would expect the manifest to be rejected by a validating webhook.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

No branches or pull requests

2 participants