Skip to content
This repository has been archived by the owner on Oct 16, 2023. It is now read-only.

Units of noise levels in Instrument #22

Open
dpole opened this issue Apr 25, 2018 · 2 comments
Open

Units of noise levels in Instrument #22

dpole opened this issue Apr 25, 2018 · 2 comments

Comments

@dpole
Copy link

dpole commented Apr 25, 2018

Hi,
I am confused about the units of the noise levels in Instrument.
The doc says that they are expected to be in uK_RJarcmin
https://github.com/bthorne93/PySM_public/blob/b3e23bb8f88182bf440b731a2bab7100a255af0d/pysm/pysm.py#L147

However, from here
https://github.com/bthorne93/PySM_public/blob/b3e23bb8f88182bf440b731a2bab7100a255af0d/pysm/pysm.py#L475
and
https://github.com/bthorne93/PySM_public/blob/b3e23bb8f88182bf440b731a2bab7100a255af0d/pysm/pysm.py#L532
I understand that the noise levels are expected in uK_CMBarcmin.

If you confirm that sens_I and sens_P are actually expected in CMB units I can open a pull request that changes the doc of Instrument
Thanks

@dpole dpole changed the title Units of noise levels Units of noise levels in Intrument Apr 25, 2018
@dpole dpole changed the title Units of noise levels in Intrument Units of noise levels in Instrument Apr 25, 2018
@dpole
Copy link
Author

dpole commented Sep 18, 2018

Hi, if some developer could confirm or refute my understanding, it would be very useful: I am relying on this for several analyses. Thanks a lot for any help on this and for the library in general.

@b-thorne
Copy link
Owner

Hi, This does look like a typo in the documentation, and should be uK_CMB. Please do go ahead and open a PR, thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants