Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spike on how we enable static frontend apps for simplified init #2750

Closed
Tracked by #2654
savannahostrowski opened this issue Sep 15, 2023 · 2 comments · Fixed by #2900
Closed
Tracked by #2654

Spike on how we enable static frontend apps for simplified init #2750

savannahostrowski opened this issue Sep 15, 2023 · 2 comments · Fixed by #2900
Assignees
@weikanglim
Labels
golden-path Improvements to the getting started experience + golden path (local dev -> first deploy)
Milestone
November 2023 - 1...

Comments

@savannahostrowski
Copy link
Contributor

Right now, buildpacks don't support this scenario and there's "magic"/"hacks" to make it work which make it a non-starter for the new init flow.
@savannahostrowski savannahostrowski added the golden-path Improvements to the getting started experience + golden path (local dev -> first deploy) label Sep 15, 2023
@savannahostrowski savannahostrowski changed the title Spike on how we enable static frontend apps Spike on how we enable static frontend apps for simplified init Sep 15, 2023
@savannahostrowski savannahostrowski mentioned this issue Sep 15, 2023
Closed
14 tasks
@weikanglim
Copy link
Contributor

Current plan is to enable azd to influence Oryx to install + launch a static content webserver (likely nginx) to serve the static file content on the system.

This will require Oryx (w/ node runtime) to surface configuration options to achieve the target.

@weikanglim
Copy link
Contributor

Oryx team will provide nginx capabilities long-term. Short-term, azd will be configuring the runtime image to achieve the hosting requirements

@weikanglim weikanglim mentioned this issue Oct 23, 2023
Merged
weikanglim added a commit that referenced this issue Oct 27, 2023
@weikanglim
Add static frontend support for azd buildpacks (#2900)
29093c6 
When a containerized static frontend (with no Dockerfile) specifies an output directory `dist`, azd will configure Oryx builder to serve static content from the output directory using nginx.

The azure.yaml generation logic in simplified init is updated to include better `dist` defaults for specific web frameworks, supporting angular, react, and vue at minimum.

Finally, Oryx has surfaced `ORYX_RUNTIME_PORT` as a configuration knob. azd will always set this to port 80 for consistency and avoid dealing with language-specific ports.

Fixes #2750
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@weikanglim weikanglim

Labels
golden-path Improvements to the getting started experience + golden path (local dev -> first deploy)
Projects
None yet
Milestone
November 2023 - 1.5.0
Development

Successfully merging a pull request may close this issue.

Add static frontend support for azd buildpacks weikanglim/azure-dev
3 participants
@weikanglim @savannahostrowski @rajeshkamal5050