Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong README for todo-csharp-cosmos-sql (not Mongo!) #2527

Closed
savannahostrowski opened this issue Jul 12, 2023 · 2 comments · Fixed by #2611
Closed

Wrong README for todo-csharp-cosmos-sql (not Mongo!) #2527

savannahostrowski opened this issue Jul 12, 2023 · 2 comments · Fixed by #2611
Assignees
Labels
bug Something isn't working templates

Comments

@savannahostrowski
Copy link
Contributor

savannahostrowski commented Jul 12, 2023

https://github.com/Azure-Samples/todo-csharp-cosmos-sql. We reference MongoDB but this should be SQL?

image

image

See arch diagram and also https://github.com/Azure-Samples/todo-csharp-cosmos-sql/blob/main/infra/main.bicep
image

@rajeshkamal5050
Copy link

@jongio @vhvb1989 do you know if this todo-csharp-cosmos-sql does provision Cosmos DB(MongoDB API) similar to todo-java-mongo and todo-nodejs-mongo?

@rajeshkamal5050 rajeshkamal5050 added bug Something isn't working templates labels Aug 8, 2023
@rajeshkamal5050 rajeshkamal5050 added this to the September 2023 - 1.3.0 milestone Aug 8, 2023
@vhvb1989
Copy link
Member

vhvb1989 commented Aug 8, 2023

@rajeshkamal5050 , yes, it uses cosmos-sql-db (see: https://github.com/Azure-Samples/todo-csharp-cosmos-sql/blob/main/infra/app/db.bicep#L26)

The template name is good. The readme needs to be updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working templates
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants