Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve documentation on pre/post command hooks #2224

Closed
savannahostrowski opened this issue May 15, 2023 · 5 comments
Closed

Improve documentation on pre/post command hooks #2224

savannahostrowski opened this issue May 15, 2023 · 5 comments
Assignees
@gkulin
Labels
documentation Improvements or additions to documentation
Milestone
August 2023 - 1.2.0

Comments

@savannahostrowski
Copy link
Contributor

"Pre/post scripts also cool, but still I'm not entirely clear about the flow of environment variables into them/out of them"
@savannahostrowski savannahostrowski added the documentation Improvements or additions to documentation label May 15, 2023
@savannahostrowski savannahostrowski added this to the Gallium milestone May 15, 2023
@savannahostrowski
Copy link
Contributor Author

@gkulin What iteration should this be assigned to? August? September?

@gkulin
Copy link
Collaborator

gkulin commented Jul 25, 2023

August will work! @savannahostrowski

@savannahostrowski
Copy link
Contributor Author

savannahostrowski commented Jul 25, 2023 •
edited

Might be good to consider also adding details about how to consume environment variables via hooks here, as I've heard that come up a couple times.

See https://github.com/Azure-Samples/azure-search-openai-demo/blob/main/scripts/prepdocs.ps1 as an example

@rajeshkamal5050 rajeshkamal5050 mentioned this issue Aug 8, 2023
Closed
@rajeshkamal5050
Copy link

rajeshkamal5050 commented Aug 8, 2023 •
edited

@gkulin similar issue #2607 and its discussion #1613 (reply in thread)

Is this incorporated for the upcoming release i.e., Aug 9 1.2.0? cc @vhvb1989 @wbreza

@gkulin
Copy link
Collaborator

gkulin commented Aug 9, 2023

completed via https://github.com/MicrosoftDocs/azure-dev-docs-pr/pull/4774

@gkulin gkulin closed this as completed Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gkulin gkulin

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
August 2023 - 1.2.0
Development

No branches or pull requests
3 participants
@savannahostrowski @rajeshkamal5050 @gkulin