Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support refactor/rename #31

Open
jan-xyz opened this issue Feb 29, 2024 · 4 comments
Open

Support refactor/rename #31

jan-xyz opened this issue Feb 29, 2024 · 4 comments

Comments

@jan-xyz
Copy link
Contributor

jan-xyz commented Feb 29, 2024

Have you thought about also supporting refactor/rename? It supports the same mechanism as code actions and it would be really nice to also have it!

@aznhe21
Copy link
Owner

aznhe21 commented Mar 9, 2024

Good idea! The implementation doesn't seem particularly difficult either. However, it will take time to get the overall balance and UI right. Please wait a while.

@pidgeon777
Copy link

I confirm it would be simply great.

It would give us a chance to preview the effect of the LSP rename/refactor action before actually applying it.

This mean for example:

  • Replacements in all of the involved files (opened or not)
  • Files rename

and so on, according to the LSP capabilities.

Finally, I think that actually there are no plugins supporting such a feature, so yours would be the first one to implement it.

@jan-xyz
Copy link
Contributor Author

jan-xyz commented Mar 27, 2024

@pidgeon777 I spend some time on a similar plugin, and I would be interested to get your feedback, as it also implements refactor/rename: https://github.com/jan-xyz/lsp-preview.nvim

@pidgeon777
Copy link

I just gave a look at your plugin and it seems to be a great one. Congratulations for the work 👍.

I'll open specific issues in your repository to discuss about any improvements or found bugs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants