Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New release? #129

Open
dexgs opened this issue Mar 4, 2023 · 5 comments
Open

New release? #129

dexgs opened this issue Mar 4, 2023 · 5 comments
Milestone

Comments

@dexgs
Copy link

dexgs commented Mar 4, 2023

There are now several features on the main branch (bot connections, new .proto) that are missing from the 1.6 release. Is it possible to make a new release so these features can be used in botamusique and other projects?

@azlux
Copy link
Owner

azlux commented Mar 9, 2023

You're right
I should make a new release. I will prepare that.

@azlux azlux added this to the v1.7 milestone Mar 9, 2023
@azlux
Copy link
Owner

azlux commented Mar 9, 2023

https://pypi.org/project/pymumble/1.7/

@azlux azlux closed this as completed Mar 9, 2023
@dexgs
Copy link
Author

dexgs commented Mar 10, 2023

I just tried this out, I think mumble_pb2.py needs to be updated.

@dexgs
Copy link
Author

dexgs commented Mar 10, 2023

More specifically, the issue I ran into was that the generated Authenticate class is missing the client_type field which raises an error in the connect method. re-generating mumble_pb2.py with the latest Mumble.proto was enough to fix it for me.

@azlux azlux reopened this Mar 10, 2023
@DuckBoss
Copy link

Hi, I'm encountering this issue as well.
A temporary work around I'm using is just commenting out this line:

authenticate.client_type = self.client_type

So far no issues with leaving that line out for development purposes.

GameOneYT added a commit to GameOneYT/pymumble that referenced this issue May 3, 2023
GameOneYT added a commit to GameOneYT/pymumble that referenced this issue May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants