[migration] Nvim 0.9 Support #627

Jint-lzxy · 2023-04-08T05:11:13Z

Jint-lzxy · 2023-04-08T20:06:52Z

Check before merging

Sometimes nvim crashes during exit (:q) (SIGABRT), but it cannot be reliably reproduced. This would need to be tested on more platforms.

However, this issue only occurs after most plugins have been registered & loaded (e.g., a few seconds after opening a file for editing). Exiting from the dashboard will not lead to this issue, and nvim --clean doesn't lead to this issue either.

Backtrace points to nvim trying to close a handle that is either already closed or in a closing state. Blindly guessing, this should be related to a specific plugin (a pipeline created was released too early):

assert(!uv__is_closing(handle)); // evaluates to assert(!true)

Current workaround:

diff --git a/src/nvim/event/stream.c b/src/nvim/event/stream.c
index 0a49186..9150873 100644
--- a/src/nvim/event/stream.c
+++ b/src/nvim/event/stream.c
@@ -139,7 +139,9 @@ void stream_close_handle(Stream *stream)
            (void *)stream,
            uv_stream_get_write_queue_size(stream->uvstream));
     }
-    uv_close((uv_handle_t *)stream->uvstream, close_cb);
+    if (!uv_is_closing((uv_handle_t *)stream->uvstream)) {
+      uv_close((uv_handle_t *)stream->uvstream, close_cb);
+    }
   } else {
     uv_close((uv_handle_t *)&stream->uv.idle, close_cb);
   }

Full stack backtrace (debug):

Process:               nvim [719]
Path:                  /Users/USER/Desktop/*/nvim
Code Type:             X86-64 (Native)
Parent Process:        Exited process [718]
Responsible:           iTerm2 [502]
User ID:               501

Crashed Thread:        0  Dispatch queue: com.apple.main-thread

Exception Type:        EXC_CRASH (SIGABRT)
Exception Codes:       0x0000000000000000, 0x0000000000000000

Thread 0 Crashed::  Dispatch queue: com.apple.main-thread
0   libsystem_kernel.dylib        	    0x7ff808b321f2 __pthread_kill + 10
1   libsystem_pthread.dylib       	    0x7ff808b69ee6 pthread_kill + 263
2   libsystem_c.dylib             	    0x7ff808a90b45 abort + 123
3   libsystem_c.dylib             	    0x7ff808a8fe5e __assert_rtn + 314
4   nvim                          	       0x1038a3f74 uv_close + 84 (core.c:117)
5   nvim                          	       0x10350b2bd stream_close_handle + 157 (stream.c:142)
6   nvim                          	       0x10350bd21 write_cb + 209 (wstream.c:145)
7   nvim                          	       0x1038b7e8e uv__write_callbacks + 542 (stream.c:927)
8   nvim                          	       0x1038b7c10 uv__stream_destroy + 336 (stream.c:456)
9   nvim                          	       0x1038a7745 uv__finish_close + 293 (core.c:304)
10  nvim                          	       0x1038a48aa uv__run_closing_handles + 74 (core.c:334)
11  nvim                          	       0x1038a4644 uv_run + 404 (core.c:425)
12  nvim                          	       0x103506117 loop_close + 215 (loop.c:166)
13  nvim                          	       0x1033c6b09 event_teardown + 137 (main.c:170)
14  nvim                          	       0x1033cad83 os_exit + 67 (main.c:662)
15  nvim                          	       0x1033ca7d5 getout + 1493 (main.c:799)
16  nvim                          	       0x103529368 ex_exit + 360 (ex_docmd.c:4877)
17  nvim                          	       0x103521f7e execute_cmd0 + 894 (ex_docmd.c:1620)
18  nvim                          	       0x10351dbf9 do_one_cmd + 4921 (ex_docmd.c:2279)
19  nvim                          	       0x10351b697 do_cmdline + 2887 (ex_docmd.c:578)
20  nvim                          	       0x10361372d nv_colon + 349 (normal.c:3228)
21  nvim                          	       0x1036111a8 normal_execute + 2136 (normal.c:1196)
22  nvim                          	       0x10370d37a state_enter + 538 (state.c:99)
23  nvim                          	       0x10360d185 normal_enter + 165 (normal.c:497)
24  nvim                          	       0x1033c7d1d main + 4045 (main.c:641)
25  dyld                          	    0x7ff80881041f start + 1903

Binary Images:
       0x1033c4000 -        0x103947fff nvim (*) <d547b91c-293a-3321-a609-7c36d55e050b> /Users/USER/Desktop/*/nvim
       0x103b7c000 -        0x103b87fff libintl.8.dylib (*) <146b350b-3118-3f81-aab0-b6792d3d810d> /usr/local/Cellar/gettext/0.21.1/lib/libintl.8.dylib
       0x1043cd000 -        0x1043d8fff lua.so (*) <f3f2e975-b3d2-3058-ad51-d238961a1b1d> /Users/USER/*/lua.so
       0x103d5b000 -        0x103d5efff libfzy-darwin-x86_64.so (*) <e0be7cbb-ce8f-3b19-883f-541e85282aaf> /Users/USER/*/libfzy-darwin-x86_64.so
    0x7ff808b2a000 -     0x7ff808b63ff7 libsystem_kernel.dylib (*) <08606a44-7008-3658-9f00-6c250b80e9c3> /usr/lib/system/libsystem_kernel.dylib
    0x7ff808b64000 -     0x7ff808b6ffff libsystem_pthread.dylib (*) <86dfa543-95fa-36b4-83c6-bf03d01b2aad> /usr/lib/system/libsystem_pthread.dylib
    0x7ff808a11000 -     0x7ff808a98ff7 libsystem_c.dylib (*) <0773ddbc-707e-3b56-ad3e-97aaa9b2c3ed> /usr/lib/system/libsystem_c.dylib
    0x7ff80880a000 -     0x7ff8088a25a7 dyld (*) <afa3518c-143e-3060-bbe8-624d4ca41063> /usr/lib/dyld
    0x7ff808bc9000 -     0x7ff809065fef com.apple.CoreFoundation (6.9) <315a3f65-0954-3635-96dc-2f65c691d074> /System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation

cc @ayamir @CharlesChiuGit

ayamir · 2023-04-09T04:43:22Z

Maybe we can checkout a 0.8 branch before merge changes for 0.9.

Jint-lzxy · 2023-04-09T05:05:12Z

Maybe we can checkout a 0.8 branch before merge changes for 0.9.

tree#0.8

ayamir · 2023-04-09T16:10:30Z

Check before merging

Sometimes nvim crashes during exit (:q) (SIGABRT), but it cannot be reliably reproduced. This would need to be tested on more platforms.

However, this issue only occurs after most plugins have been registered & loaded (e.g., a few seconds after opening a file for editing). Exiting from the dashboard will not lead to this issue, and nvim --clean doesn't lead to this issue either.

Backtrace points to nvim trying to close a handle that is either already closed or in a closing state. Blindly guessing, this should be related to a specific plugin (a pipeline created was released too early):

assert(!uv__is_closing(handle)); // evaluates to assert(!true)

Current workaround:

diff --git a/src/nvim/event/stream.c b/src/nvim/event/stream.c
index 0a49186..9150873 100644
--- a/src/nvim/event/stream.c
+++ b/src/nvim/event/stream.c
@@ -139,7 +139,9 @@ void stream_close_handle(Stream *stream)
            (void *)stream,
            uv_stream_get_write_queue_size(stream->uvstream));
     }
-    uv_close((uv_handle_t *)stream->uvstream, close_cb);
+    if (!uv_is_closing((uv_handle_t *)stream->uvstream)) {
+      uv_close((uv_handle_t *)stream->uvstream, close_cb);
+    }
   } else {
     uv_close((uv_handle_t *)&stream->uv.idle, close_cb);
   }

Full stack backtrace (debug):

Process:               nvim [719]
Path:                  /Users/USER/Desktop/*/nvim
Code Type:             X86-64 (Native)
Parent Process:        Exited process [718]
Responsible:           iTerm2 [502]
User ID:               501

Crashed Thread:        0  Dispatch queue: com.apple.main-thread

Exception Type:        EXC_CRASH (SIGABRT)
Exception Codes:       0x0000000000000000, 0x0000000000000000

Thread 0 Crashed::  Dispatch queue: com.apple.main-thread
0   libsystem_kernel.dylib        	    0x7ff808b321f2 __pthread_kill + 10
1   libsystem_pthread.dylib       	    0x7ff808b69ee6 pthread_kill + 263
2   libsystem_c.dylib             	    0x7ff808a90b45 abort + 123
3   libsystem_c.dylib             	    0x7ff808a8fe5e __assert_rtn + 314
4   nvim                          	       0x1038a3f74 uv_close + 84 (core.c:117)
5   nvim                          	       0x10350b2bd stream_close_handle + 157 (stream.c:142)
6   nvim                          	       0x10350bd21 write_cb + 209 (wstream.c:145)
7   nvim                          	       0x1038b7e8e uv__write_callbacks + 542 (stream.c:927)
8   nvim                          	       0x1038b7c10 uv__stream_destroy + 336 (stream.c:456)
9   nvim                          	       0x1038a7745 uv__finish_close + 293 (core.c:304)
10  nvim                          	       0x1038a48aa uv__run_closing_handles + 74 (core.c:334)
11  nvim                          	       0x1038a4644 uv_run + 404 (core.c:425)
12  nvim                          	       0x103506117 loop_close + 215 (loop.c:166)
13  nvim                          	       0x1033c6b09 event_teardown + 137 (main.c:170)
14  nvim                          	       0x1033cad83 os_exit + 67 (main.c:662)
15  nvim                          	       0x1033ca7d5 getout + 1493 (main.c:799)
16  nvim                          	       0x103529368 ex_exit + 360 (ex_docmd.c:4877)
17  nvim                          	       0x103521f7e execute_cmd0 + 894 (ex_docmd.c:1620)
18  nvim                          	       0x10351dbf9 do_one_cmd + 4921 (ex_docmd.c:2279)
19  nvim                          	       0x10351b697 do_cmdline + 2887 (ex_docmd.c:578)
20  nvim                          	       0x10361372d nv_colon + 349 (normal.c:3228)
21  nvim                          	       0x1036111a8 normal_execute + 2136 (normal.c:1196)
22  nvim                          	       0x10370d37a state_enter + 538 (state.c:99)
23  nvim                          	       0x10360d185 normal_enter + 165 (normal.c:497)
24  nvim                          	       0x1033c7d1d main + 4045 (main.c:641)
25  dyld                          	    0x7ff80881041f start + 1903

Binary Images:
       0x1033c4000 -        0x103947fff nvim (*) <d547b91c-293a-3321-a609-7c36d55e050b> /Users/USER/Desktop/*/nvim
       0x103b7c000 -        0x103b87fff libintl.8.dylib (*) <146b350b-3118-3f81-aab0-b6792d3d810d> /usr/local/Cellar/gettext/0.21.1/lib/libintl.8.dylib
       0x1043cd000 -        0x1043d8fff lua.so (*) <f3f2e975-b3d2-3058-ad51-d238961a1b1d> /Users/USER/*/lua.so
       0x103d5b000 -        0x103d5efff libfzy-darwin-x86_64.so (*) <e0be7cbb-ce8f-3b19-883f-541e85282aaf> /Users/USER/*/libfzy-darwin-x86_64.so
    0x7ff808b2a000 -     0x7ff808b63ff7 libsystem_kernel.dylib (*) <08606a44-7008-3658-9f00-6c250b80e9c3> /usr/lib/system/libsystem_kernel.dylib
    0x7ff808b64000 -     0x7ff808b6ffff libsystem_pthread.dylib (*) <86dfa543-95fa-36b4-83c6-bf03d01b2aad> /usr/lib/system/libsystem_pthread.dylib
    0x7ff808a11000 -     0x7ff808a98ff7 libsystem_c.dylib (*) <0773ddbc-707e-3b56-ad3e-97aaa9b2c3ed> /usr/lib/system/libsystem_c.dylib
    0x7ff80880a000 -     0x7ff8088a25a7 dyld (*) <afa3518c-143e-3060-bbe8-624d4ca41063> /usr/lib/dyld
    0x7ff808bc9000 -     0x7ff809065fef com.apple.CoreFoundation (6.9) <315a3f65-0954-3635-96dc-2f65c691d074> /System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation

cc @ayamir @CharlesChiuGit

I'm waiting for the 0.9 version pr of neovim merged. So it will be tested later.

ayamir · 2023-04-09T16:20:24Z

Add suda.vim is accpetable to close #617 but whether it is necessary.

CharlesChiuGit · 2023-04-10T09:52:23Z

Check before merging

Sometimes nvim crashes during exit (:q) (SIGABRT), but it cannot be reliably reproduced. This would need to be tested on more platforms.

However, this issue only occurs after most plugins have been registered & loaded (e.g., a few seconds after opening a file for editing). Exiting from the dashboard will not lead to this issue, and nvim --clean doesn't lead to this issue either.

Backtrace points to nvim trying to close a handle that is either already closed or in a closing state. Blindly guessing, this should be related to a specific plugin (a pipeline created was released too early):

assert(!uv__is_closing(handle)); // evaluates to assert(!true)

Current workaround:

diff --git a/src/nvim/event/stream.c b/src/nvim/event/stream.c
index 0a49186..9150873 100644
--- a/src/nvim/event/stream.c
+++ b/src/nvim/event/stream.c
@@ -139,7 +139,9 @@ void stream_close_handle(Stream *stream)
            (void *)stream,
            uv_stream_get_write_queue_size(stream->uvstream));
     }
-    uv_close((uv_handle_t *)stream->uvstream, close_cb);
+    if (!uv_is_closing((uv_handle_t *)stream->uvstream)) {
+      uv_close((uv_handle_t *)stream->uvstream, close_cb);
+    }
   } else {
     uv_close((uv_handle_t *)&stream->uv.idle, close_cb);
   }

Full stack backtrace (debug):

Process:               nvim [719]
Path:                  /Users/USER/Desktop/*/nvim
Code Type:             X86-64 (Native)
Parent Process:        Exited process [718]
Responsible:           iTerm2 [502]
User ID:               501

Crashed Thread:        0  Dispatch queue: com.apple.main-thread

Exception Type:        EXC_CRASH (SIGABRT)
Exception Codes:       0x0000000000000000, 0x0000000000000000

Thread 0 Crashed::  Dispatch queue: com.apple.main-thread
0   libsystem_kernel.dylib        	    0x7ff808b321f2 __pthread_kill + 10
1   libsystem_pthread.dylib       	    0x7ff808b69ee6 pthread_kill + 263
2   libsystem_c.dylib             	    0x7ff808a90b45 abort + 123
3   libsystem_c.dylib             	    0x7ff808a8fe5e __assert_rtn + 314
4   nvim                          	       0x1038a3f74 uv_close + 84 (core.c:117)
5   nvim                          	       0x10350b2bd stream_close_handle + 157 (stream.c:142)
6   nvim                          	       0x10350bd21 write_cb + 209 (wstream.c:145)
7   nvim                          	       0x1038b7e8e uv__write_callbacks + 542 (stream.c:927)
8   nvim                          	       0x1038b7c10 uv__stream_destroy + 336 (stream.c:456)
9   nvim                          	       0x1038a7745 uv__finish_close + 293 (core.c:304)
10  nvim                          	       0x1038a48aa uv__run_closing_handles + 74 (core.c:334)
11  nvim                          	       0x1038a4644 uv_run + 404 (core.c:425)
12  nvim                          	       0x103506117 loop_close + 215 (loop.c:166)
13  nvim                          	       0x1033c6b09 event_teardown + 137 (main.c:170)
14  nvim                          	       0x1033cad83 os_exit + 67 (main.c:662)
15  nvim                          	       0x1033ca7d5 getout + 1493 (main.c:799)
16  nvim                          	       0x103529368 ex_exit + 360 (ex_docmd.c:4877)
17  nvim                          	       0x103521f7e execute_cmd0 + 894 (ex_docmd.c:1620)
18  nvim                          	       0x10351dbf9 do_one_cmd + 4921 (ex_docmd.c:2279)
19  nvim                          	       0x10351b697 do_cmdline + 2887 (ex_docmd.c:578)
20  nvim                          	       0x10361372d nv_colon + 349 (normal.c:3228)
21  nvim                          	       0x1036111a8 normal_execute + 2136 (normal.c:1196)
22  nvim                          	       0x10370d37a state_enter + 538 (state.c:99)
23  nvim                          	       0x10360d185 normal_enter + 165 (normal.c:497)
24  nvim                          	       0x1033c7d1d main + 4045 (main.c:641)
25  dyld                          	    0x7ff80881041f start + 1903

Binary Images:
       0x1033c4000 -        0x103947fff nvim (*) <d547b91c-293a-3321-a609-7c36d55e050b> /Users/USER/Desktop/*/nvim
       0x103b7c000 -        0x103b87fff libintl.8.dylib (*) <146b350b-3118-3f81-aab0-b6792d3d810d> /usr/local/Cellar/gettext/0.21.1/lib/libintl.8.dylib
       0x1043cd000 -        0x1043d8fff lua.so (*) <f3f2e975-b3d2-3058-ad51-d238961a1b1d> /Users/USER/*/lua.so
       0x103d5b000 -        0x103d5efff libfzy-darwin-x86_64.so (*) <e0be7cbb-ce8f-3b19-883f-541e85282aaf> /Users/USER/*/libfzy-darwin-x86_64.so
    0x7ff808b2a000 -     0x7ff808b63ff7 libsystem_kernel.dylib (*) <08606a44-7008-3658-9f00-6c250b80e9c3> /usr/lib/system/libsystem_kernel.dylib
    0x7ff808b64000 -     0x7ff808b6ffff libsystem_pthread.dylib (*) <86dfa543-95fa-36b4-83c6-bf03d01b2aad> /usr/lib/system/libsystem_pthread.dylib
    0x7ff808a11000 -     0x7ff808a98ff7 libsystem_c.dylib (*) <0773ddbc-707e-3b56-ad3e-97aaa9b2c3ed> /usr/lib/system/libsystem_c.dylib
    0x7ff80880a000 -     0x7ff8088a25a7 dyld (*) <afa3518c-143e-3060-bbe8-624d4ca41063> /usr/lib/dyld
    0x7ff808bc9000 -     0x7ff809065fef com.apple.CoreFoundation (6.9) <315a3f65-0954-3635-96dc-2f65c691d074> /System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation

cc @ayamir @CharlesChiuGit

This is interesting, I never ran into this when I drove 0.9-dev on void, arch and ubuntu. I'll test the non-dev version again.
Is this error happens on macos?

Jint-lzxy · 2023-04-10T11:48:29Z

Is this error happens on macos?

Yep.

This is interesting, I never ran into this when I drove 0.9-dev on void, arch and ubuntu. I'll test the non-dev version again.

After attaching a debugger to nvim (about to crash), looks like sometimes uv_close is called by an autocmd (a uv_handle_t*) registered by a plugin (whose information can't be obtained as we're directly debugging an executable) that will trigger at VimLeavePre. Current observation indicates that only this callback would lead to a crash when calling external shell commands. The following:

vim.api.nvim_create_autocmd("VimLeavePre", {
	callback = function()
		vim.api.nvim_command([[silent! !echo 'aMessage']])
	end,
})

can reliably reproduce this crash on macOS. idk whether this behavior is the same on other platforms 😄

Jint-lzxy · 2023-04-10T12:12:50Z

Add suda.vim is accpetable to close #617 but whether it is necessary.

no problem with this, as we just need to load it on demand. A possible implementation:

{scope}["lambdalisue/suda.vim"] = {
	lazy = true,
	cmd = { "SudaRead", "SudaWrite" }
}

CharlesChiuGit · 2023-04-11T04:00:46Z

nvimdev/lspsaga.nvim@298009c

    keys = {
      exec_action = 'o',
      exec_action = 'o',
      quit = 'q',
      quit = 'q',
      ~~ go_action = 'g', ~~
      expand_or_jump = '<CR>',
      expand_or_jump = '<CR>',
      quit_in_show = { 'q', '<ESC>' },
      quit_in_show = { 'q', '<ESC>' },
    },

go_action is now removed, @Jint-lzxy r u waiting for the new release?

Also I think starting from now, we need to send PRs to 0.9 branch?

CharlesChiuGit · 2023-04-11T08:07:48Z

can reliably reproduce this crash on macOS. idk whether this behavior is the same on other platforms 😄

This doesn't seem to happen on Win11 with 0.9 (non-dev) version.

ayamir · 2023-04-11T08:41:19Z

This doesn't seem to happen on Win11 with 0.9 (non-dev) version.

Don't appear on Gentoo too.

Jint-lzxy · 2023-04-11T11:35:05Z

idk whether this behavior is the same on other platforms

Looks like this is an upstream issue: neovim/neovim#21856.

Also I think starting from now, we need to send PRs to 0.9 branch?

In fact, all previous PRs were sent to the 0.9 branch 😄

go_action is now removed

Oh well spotted! I somehow didn't notice this change

EDIT: Fixed at ac3122d.

fecet · 2023-04-26T07:53:44Z

It seems like our winbar is not currently enabled. Is this intentional?

CharlesChiuGit · 2023-04-26T08:36:32Z

It seems like our winbar is not currently enabled. Is this intentional?

@fecet
ys, we tried it before, but it didn't work out well.
It loads a bit later when the buffer is opened and causes the screen to shake a bit, especially on a slower machine. That's why we decide to move the lsp breadcrumbs to lualine to improve the user experience.

Jint-lzxy · 2023-04-27T12:14:12Z

@fecet FYI: #398 and #402.

fecet · 2023-04-27T14:11:01Z

@fecet FYI: #398 and #402.

I'm adding https://github.com/SmiteshP/nvim-navbuddy to my config, so I can write a winbar PR based on nvim-navic if you find it useful. Also, the functionality mentioned in #398 should have been fixed in neovim 0.9 version as @CharlesChiuGit mentioned(I'm using lspsaga's winbar and it works well), so I think it might be appropriate to bring it back in this branch.

The current solution doesn't work well for me because lsp symbols can be very long and lualine already takes up a lot of space on both sides.

CharlesChiuGit · 2023-04-27T14:14:17Z

maybe we cau just use lspsaga's winbar functionality, not need extra two plugins lol.

maybe we can see a demo pr first?

The current solution doesn't work well for me because lsp symbols can be very long and lualine already takes up a lot of space on both sides.

agree with that. if the buffer won't jitter, i would prefer winbar too.

fecet · 2023-04-27T14:33:26Z

maybe we cau just use lspsaga's winbar functionality, not need extra two plugins lol.

Maybe we should discuss if adding navbuddy? Since otherwise all we need to do is set option in lspsaga to true. I dont quite know how to sugget a new plugin in this project, though it's lightweight enough and should not hurt startuptime much.

CharlesChiuGit · 2023-04-28T01:50:29Z

I dont quite know how to sugget a new plugin in this project, though it's lightweight enough and should not hurt startuptime much.

Normally I just test the plugin for a while and see if there's any weird things, if I use it a lot then I'll post in #494.

Maybe we should discuss if adding navbuddy?

I checked this plugin before when I was looking for sth like https://github.com/ziontee113/syntax-tree-surfer and https://github.com/mfussenegger/nvim-treehopper, but navbuddy need too much dependencies and navic offers pretty much the same as lspsaga, I don't want extra plugin doing the same thing; therefore, I drop it.

fecet · 2023-04-28T19:37:43Z

I have suggested the author of lspsaga to add functionality like navbuddy, he said he would implement that in a different but better way to replace current outline function. So I agree waitting is a wise choice.

CharlesChiuGit · 2023-04-29T02:54:40Z

I have suggested the author of lspsaga to add functionality like navbuddy, he said he would implement that in a different but better way to replace current outline function. So I agree waitting is a wise choice.

that would be nice!

Jint-lzxy · 2023-04-30T15:53:09Z

The current solution doesn't work well for me because lsp symbols can be very long and lualine already takes up a lot of space on both sides.

💯💯 Agreed. Yes that PR (#402) actually served as a workaround for a defect introduced in nvim v0.8 + lspsaga (which was fixed later in 0.9-dev). Many thanks for pointing this out 👍 It was proposed "ages ago" and I completely forgot this.

btw, we could also fill lualine-c with other plugins like git blame.

Jint-lzxy · 2024-05-22T08:06:18Z

Closing in favor of #1259.

Jint-lzxy added enhancement New feature or request complexity:high High-risk, potential for delicate/cascading effects labels Apr 8, 2023

Jint-lzxy mentioned this issue Apr 11, 2023

feat(alpha): add custom highlight groups #650

Merged

Jint-lzxy mentioned this issue Apr 21, 2023

refactor(catppuccin)!: reimplement basic hl groups #676

Draft

Jint-lzxy mentioned this issue Apr 26, 2023

How to add a new colorscheme #691

Closed

2 tasks

Jint-lzxy mentioned this issue Jul 14, 2023

Improve user experience wrt transparent backgrounds #864

Closed

ayamir mentioned this issue Jul 22, 2023

refactor (user custom): Proposal for enhancing user customization experience #885

Closed

Jint-lzxy closed this as completed May 22, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[migration] Nvim 0.9 Support #627

[migration] Nvim 0.9 Support #627

Jint-lzxy commented Apr 8, 2023 •

edited

Jint-lzxy commented Apr 8, 2023 •

edited

ayamir commented Apr 9, 2023

Jint-lzxy commented Apr 9, 2023

ayamir commented Apr 9, 2023

Check before merging

ayamir commented Apr 9, 2023

CharlesChiuGit commented Apr 10, 2023 •

edited

Check before merging

Jint-lzxy commented Apr 10, 2023

Jint-lzxy commented Apr 10, 2023

CharlesChiuGit commented Apr 11, 2023 •

edited

CharlesChiuGit commented Apr 11, 2023

ayamir commented Apr 11, 2023

Jint-lzxy commented Apr 11, 2023 •

edited

fecet commented Apr 26, 2023

CharlesChiuGit commented Apr 26, 2023 •

edited

Jint-lzxy commented Apr 27, 2023

fecet commented Apr 27, 2023 •

edited

CharlesChiuGit commented Apr 27, 2023 •

edited

fecet commented Apr 27, 2023 •

edited

CharlesChiuGit commented Apr 28, 2023 •

edited

fecet commented Apr 28, 2023 •

edited

CharlesChiuGit commented Apr 29, 2023

Jint-lzxy commented Apr 30, 2023 •

edited

Jint-lzxy commented May 22, 2024

[migration] Nvim 0.9 Support #627

[migration] Nvim 0.9 Support #627

Comments

Jint-lzxy commented Apr 8, 2023 • edited

Feature description

Additional information

Linked issues

Jint-lzxy commented Apr 8, 2023 • edited

Check before merging

ayamir commented Apr 9, 2023

Jint-lzxy commented Apr 9, 2023

ayamir commented Apr 9, 2023

Check before merging

ayamir commented Apr 9, 2023

CharlesChiuGit commented Apr 10, 2023 • edited

Check before merging

Jint-lzxy commented Apr 10, 2023

Jint-lzxy commented Apr 10, 2023

CharlesChiuGit commented Apr 11, 2023 • edited

CharlesChiuGit commented Apr 11, 2023

ayamir commented Apr 11, 2023

Jint-lzxy commented Apr 11, 2023 • edited

fecet commented Apr 26, 2023

CharlesChiuGit commented Apr 26, 2023 • edited

Jint-lzxy commented Apr 27, 2023

fecet commented Apr 27, 2023 • edited

CharlesChiuGit commented Apr 27, 2023 • edited

fecet commented Apr 27, 2023 • edited

CharlesChiuGit commented Apr 28, 2023 • edited

fecet commented Apr 28, 2023 • edited

CharlesChiuGit commented Apr 29, 2023

Jint-lzxy commented Apr 30, 2023 • edited

Jint-lzxy commented May 22, 2024

Jint-lzxy commented Apr 8, 2023 •

edited

Jint-lzxy commented Apr 8, 2023 •

edited

CharlesChiuGit commented Apr 10, 2023 •

edited

CharlesChiuGit commented Apr 11, 2023 •

edited

Jint-lzxy commented Apr 11, 2023 •

edited

CharlesChiuGit commented Apr 26, 2023 •

edited

fecet commented Apr 27, 2023 •

edited

CharlesChiuGit commented Apr 27, 2023 •

edited

fecet commented Apr 27, 2023 •

edited

CharlesChiuGit commented Apr 28, 2023 •

edited

fecet commented Apr 28, 2023 •

edited

Jint-lzxy commented Apr 30, 2023 •

edited