Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: unify workspace code style #1622

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

style: unify workspace code style #1622

wants to merge 5 commits into from
+2,458 −2,450

Conversation

KaoImin
Copy link
Contributor

@KaoImin KaoImin commented Dec 6, 2023 •
edited by Flouse

What this PR does / why we need it?

This PR unify Axon code style using https://github.com/oxsecurity/megalinter:

  • Replace all the tabs with whitespaces
  • Trim trailing whitespaces or tabs
  • Add blank lines at the end of files
  • Replace all the CRLF to LF

What is the impact of this PR?

No Breaking Change

PR relation:

CI Settings

CI Usage

Tip: Check the CI you want to run below, and then comment /run-ci.

CI Switch

  • Web3 Compatible Tests
  • OpenZeppelin tests
  • v3 Core Tests

CI Description

CI Name Description
Web3 Compatible Test Test the Web3 compatibility of Axon
v3 Core Test Run the compatibility tests provided by Uniswap V3
OpenZeppelin tests Run the compatibility tests provided by OpenZeppelin, including OCT 1-5 | 6-10 | 11 | 12-15 | 16-19

@KaoImin KaoImin requested a review from a team as a code owner December 6, 2023 06:57
@github-actions github-actions bot added the style label Dec 6, 2023
@KaoImin KaoImin requested review from Flouse and yangby-cryptape and removed request for jjyr and ashuralyk December 6, 2023 06:58
@yangby-cryptape
Copy link
Collaborator

The key point of the issue is not how to fix, is how to prevent.
Your PR doesn't resolve that.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 7, 2023 •
edited

🦙 MegaLinter status: ❌ ERROR

Descriptor Linter Files Fixed Errors Elapsed time
❌ ACTION actionlint 26 46 0.39s
✅ BASH bash-exec 3 0 0.01s
❌ BASH shellcheck 3 22 0.07s
✅ BASH shfmt 3 2 0 0.05s
❌ COPYPASTE jscpd yes 435 14.17s
❌ DOCKERFILE hadolint 1 1 0.06s
❌ EDITORCONFIG editorconfig-checker 578 1 2.44s
✅ ENV dotenv-linter 1 1 0 0.05s
❌ HTML djlint 36 209 1.38s
❌ HTML htmlhint 36 112 0.24s
✅ JSON eslint-plugin-jsonc 12 0 0 1.25s
✅ JSON jsonlint 12 0 0.13s
✅ JSON prettier 12 3 0 0.92s
❌ JSON v8r 12 1 13.13s
⚠️ MARKDOWN markdownlint 85 6 341 6.35s
❌ MARKDOWN markdown-link-check 85 2 405.14s
✅ MARKDOWN markdown-table-formatter 85 8 0 0.33s
❌ REPOSITORY checkov yes 51 19.18s
❌ REPOSITORY gitleaks yes 166 4.14s
✅ REPOSITORY git_diff yes no 0.06s
❌ REPOSITORY grype yes 1 17.21s
✅ REPOSITORY secretlint yes no 3.02s
❌ REPOSITORY trivy yes 1 5.98s
✅ REPOSITORY trivy-sbom yes no 3.44s
✅ REPOSITORY trufflehog yes no 5.53s
✅ YAML prettier 39 26 0 2.64s
❌ YAML v8r 39 1 51.94s
❌ YAML yamllint 39 1 0.84s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

@Flouse Flouse requested a review from driftluo December 21, 2023 03:55
@github-actions GitHub Actions
Copy link

🦙 MegaLinter status: ❌ ERROR

Descriptor Linter Files Fixed Errors Elapsed time
✅ BASH bash-exec 2 0 0.01s
❌ BASH shellcheck 2 22 0.07s
✅ BASH shfmt 2 0 0 0.05s
❌ COPYPASTE jscpd yes 401 14.06s
❌ EDITORCONFIG editorconfig-checker 37 1 0.09s
✅ ENV dotenv-linter 1 0 0 0.05s
✅ JSON eslint-plugin-jsonc 5 0 0 0.97s
✅ JSON jsonlint 5 0 0.21s
❌ JSON v8r 5 1 3.99s
⚠️ MARKDOWN markdownlint 12 0 233 3.36s
⚠️ MARKDOWN markdown-link-check 12 10 43.74s
✅ MARKDOWN markdown-table-formatter 12 0 0 0.4s
❌ REPOSITORY checkov yes 49 21.48s
⚠️ REPOSITORY devskim yes 234 4.19s
✅ REPOSITORY dustilock yes no 1.88s
✅ REPOSITORY git_diff yes no 0.03s
⚠️ REPOSITORY grype yes 1 19.82s
✅ REPOSITORY secretlint yes no 3.1s
✅ REPOSITORY syft yes no 1.26s
❌ REPOSITORY trivy yes 1 15.53s
✅ REPOSITORY trivy-sbom yes no 0.98s
✅ REPOSITORY trufflehog yes no 4.13s
❌ SPELL cspell 33 183 8.49s
❌ SPELL lychee 20 13 2.73s
✅ TERRAFORM terraform-fmt 3 0 0 0.33s
❌ TERRAFORM terrascan yes 1 4.47s
❌ TERRAFORM tflint yes 1 0.16s
✅ YAML prettier 8 0 0 0.8s
✅ YAML v8r 8 0 7.82s
✅ YAML yamllint 8 0 0.54s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Flouse Flouse Awaiting requested review from Flouse

@yangby-cryptape yangby-cryptape Awaiting requested review from yangby-cryptape

@driftluo driftluo Awaiting requested review from driftluo

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
style
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

⚰️ Welcome to attend the funeral of a friend 🤡 of us.
2 participants
@KaoImin @yangby-cryptape