Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A tool or sub-command to rollback blocks. #1574

Open
yangby-cryptape opened this issue Nov 17, 2023 · 1 comment
Open

A tool or sub-command to rollback blocks. #1574

yangby-cryptape opened this issue Nov 17, 2023 · 1 comment
Labels
d:solution Discussion required for the solution. P-Low Priority P-Medium t:feature

Comments

@yangby-cryptape
Copy link
Collaborator

Description

When the size of chain data is big, re-play the whole chain is very difficult.

Without the rollback feature, use binary search to find the commit that introduced a bug is impossible.

As an example, in #1573, when I found the first good commit 9a0bdbd, my chain data was updated.
So, I could not do test again.
I only known the bug is introduced between ad4375b and 9a0bdbd.

Very lucky, there are only 9 commits between ad4375b and 9a0bdbd and 5 of them didn't update codes.

But we won't be so luck forever.
And I tried more times than a binary search could use, wasted me a lot of time.

@Flouse
Copy link
Contributor

Flouse commented Nov 24, 2023

Since #1581 has been implemented, I suggest to postpone this feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
d:solution Discussion required for the solution. P-Low Priority P-Medium t:feature
Projects
None yet
Development

No branches or pull requests

3 participants
@Flouse @yangby-cryptape and others