Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The remove operations for RocksTrieDB are no-op. #1440

Open
yangby-cryptape opened this issue Sep 19, 2023 · 1 comment
Open

The remove operations for RocksTrieDB are no-op. #1440

yangby-cryptape opened this issue Sep 19, 2023 · 1 comment
Assignees
Labels
document P-Low Priority t:bug Something isn't working

Comments

@yangby-cryptape
Copy link
Collaborator

yangby-cryptape commented Sep 19, 2023

Current Behavior

I'm not sure if they were correct, but the remove operations for RocksTrieDB are no-op.

fn remove(&self, _key: &[u8]) -> Result<(), io::Error> {
Ok(())
}
fn remove_batch(&self, _keys: &[Vec<u8>]) -> Result<(), io::Error> {
Ok(())
}

Expected Behavior

I thought these two operations should be real operations.

Anything else?

When I debug #1439, I found these two remove operation were called.

But these are not reason for that issue.

@yangby-cryptape yangby-cryptape added the t:bug Something isn't working label Sep 19, 2023
@Flouse Flouse added the agenda label Sep 19, 2023
@blckngm
Copy link
Contributor

blckngm commented Oct 16, 2023

The remove operation should be a no-op. If it actually deletes db kv, data under previous roots may become unavailable.

@Flouse Flouse added P-Low Priority and removed agenda labels Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
document P-Low Priority t:bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants