Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to set RUSTFLAGS in release.yml? #949

Open
Kodylow opened this issue Apr 20, 2024 · 2 comments
Open

How to set RUSTFLAGS in release.yml? #949

Kodylow opened this issue Apr 20, 2024 · 2 comments

Comments

@Kodylow
Copy link

Kodylow commented Apr 20, 2024

I need to set
rustflags = ["--cfg", "tokio_unstable"]

or export RUSTFLAGS="--cfg tokio_unstable"

as part of my build, but can't figure out how to get release.yml to pick it up. When I modify the release.yml generated by cargo-dist to set RUSTFLAGS inline whenever it runs build I get an error that the release.yml is dirty as part of plan.

What's the correct way to set build flags for cargo-dist as part of CI?

@conorsch
Copy link

You can append an env block to the build task and set RUSTFLAGS that way. See example here: https://github.com/penumbra-zone/penumbra/blob/b7da9ece7c81a616b6b1222592eb305a7908f61a/.github/workflows/release.yml#L108

@Kodylow
Copy link
Author

Kodylow commented Apr 22, 2024

Okay got it woorking this way, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants