Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

investigate powershell installer un-variabling PATH entries #933

Open
Gankra opened this issue Apr 15, 2024 · 0 comments
Open

investigate powershell installer un-variabling PATH entries #933

Gankra opened this issue Apr 15, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@Gankra
Copy link
Member

Gankra commented Apr 15, 2024

In the powershell installer we load, edit, and save the registry value storing (part of) the user's PATH. In testing in CI I noticed that the value of $env:UserProfile (one of the windows equivs of $HOME) in the current env was appearing in the result. This suggest to me that the values in ci were like %USERPROFILE%/.cargo/bin and in the process of reading/editing we forced those to get substituted permanently, degrading their quality.

We should:

  • not be substituting existing values
  • ideally be writing %USERPROFILE% values ourselves when appropriate (as the shell installer does)
@Gankra Gankra added the bug Something isn't working label Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant