Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: host job doesn't depend on success of custom build jobs #919

Open
connec opened this issue Apr 9, 2024 · 1 comment
Open

CI: host job doesn't depend on success of custom build jobs #919

connec opened this issue Apr 9, 2024 · 1 comment

Comments

@connec
Copy link

connec commented Apr 9, 2024

It's not clear if this is intentional behaviour or not, but the condition for the host GitHub Actions job does not depend on the outcome of any custom build jobs:

if: ${{ always() && needs.plan.outputs.publishing == 'true' && (needs.build-global-artifacts.result == 'skipped' || needs.build-global-artifacts.result == 'success')
{{%- if build_local_artifacts %}} && (needs.build-local-artifacts.result == 'skipped' || needs.build-local-artifacts.result == 'success') {{%- endif %}}
{{{- " }}" | safe }}}

@Gankra
Copy link
Member

Gankra commented Apr 10, 2024

That does indeed seem not-quite-right. I know this condition has gone through a lot of evolution, and has some really specific subtleties around the publish-a-library-which-skips-the-build-steps-but-still-runs-later-steps usecase.

This condition also used to have to handle the global step not existing, but we kinda-recently made changes that made the global step always appear in the graph.

...all that said I think it is accurate to say this should be considering custom local and global build jobs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants