Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schema claims AWS::Transfer::Server.Protocol is object instead of string #483

Open
sander-bol opened this issue Aug 18, 2022 · 0 comments
Open

Comments

@sander-bol
Copy link

AWS Transfer Family supports a list of protocols. These are defined as strings, and can be: "SFTP", "FTP", "FTPS" and "AS2". An example from the Cloudformation resource manual page:

 "Protocols": ["SFTP"],

The goformation schema defines AWS::Transfer::Server.Protocols as an array of AWS::Transfer::Server.Protocol objects.

"Protocols": {
    "items": {
        "$ref": "#/definitions/AWS::Transfer::Server.Protocol"
    },
    "type": "array"
},

which in turn are defined as simple objects.

"AWS::Transfer::Server.Protocol": {
            "additionalProperties": false,
            "properties": {},
            "type": "object"
        },

This causes schema linting to fail, because they expect an object where "SFTP" is now passed.

I believe the solution would be to remove Server.Protocol completely and replace the definition with an enum... but I have no experience with this repo, and no clue how the code generator that spits out the schema actually works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant