Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(amazonaurora): merge amazon aurora vector stores #373

Open
1 of 2 tasks
maxtybar opened this issue Apr 10, 2024 · 1 comment · May be fixed by #419
Open
1 of 2 tasks

(amazonaurora): merge amazon aurora vector stores #373

maxtybar opened this issue Apr 10, 2024 · 1 comment · May be fixed by #419
Assignees
Labels

Comments

@maxtybar
Copy link
Contributor

maxtybar commented Apr 10, 2024

Describe the feature

  1. Merge AmazonAuroraDefaultVectorStore with AmazonAuroraVectorStore.
  2. Create fromExistingAuroraVectorStore() function allowing user to use existing Aurora as a vector DB.
  3. Move models.ts in a dedicated foundation-models construct due to cross-dependencies (currently Amazon Aurora relies on models.ts which is in bedrock module and bedrock relies on amazonaurora). In the future this will also allow potential new vector stores to consume foundation-models construct without creating cross-dependencies with bedrock construct.

Use Case

To allow user bring their own Aurora db and avoid confusion having 2 similar constructs/classes.

Proposed Solution

No response

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change
@maxtybar maxtybar added the needs-triage This issue or PR still needs to be triaged. label Apr 10, 2024
@maxtybar maxtybar changed the title (module name): (short issue description) (amazonaurora): merge amazon aurora vector stores Apr 10, 2024
@maxtybar
Copy link
Contributor Author

Working on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment