Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Support Wilson Score Interval for RetainCompletenessRule #563

Open
zeotuan opened this issue Apr 19, 2024 · 0 comments · May be fixed by #567
Open

[FEATURE] Support Wilson Score Interval for RetainCompletenessRule #563

zeotuan opened this issue Apr 19, 2024 · 0 comments · May be fixed by #567
Labels
enhancement New feature or request

Comments

@zeotuan
Copy link
Contributor

zeotuan commented Apr 19, 2024 •
edited

Is your feature request related to a problem? Please describe.
Currently, RetainCompletenessRule is using the Wald Interval (Normal approximation interval) for calculating the interval but this method perform poorly when p value is close to either 0 or 1 (documented as TODO in the code itself)

Describe the solution you'd like
Switch to either Wilson score interval or maybe provide a strategy pattern so we can switch between Wilson, Wald or in future other Interval calculation techniques.

I am happy to help with this implementation.
@zeotuan zeotuan added the enhancement New feature or request label Apr 19, 2024
@zeotuan zeotuan mentioned this issue Apr 19, 2024
Merged
@zeotuan zeotuan linked a pull request May 6, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adding Wilson Score Confidence Interval Strategy zeotuan/deequ
1 participant
@zeotuan