Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SnsToSqs minimal deployable pattern barfs loud red warnings #1119

Closed
revanshine opened this issue May 8, 2024 · 3 comments · Fixed by #1122
Closed

SnsToSqs minimal deployable pattern barfs loud red warnings #1119

revanshine opened this issue May 8, 2024 · 3 comments · Fixed by #1122
Labels
bug Something isn't working needs-triage The issue or PR still needs to be triaged

Comments

@revanshine
Copy link

The minimal deployable pattern for SnsToSqs barfs loud red warnings making it difficult to understand and adopt.

Reproduction Steps

Create a CDK project and add the code from the minimal deployable pattern definition here:
https://constructs.dev/packages/@aws-solutions-constructs/aws-sns-sqs/v/2.57.0?lang=typescript

Error Log

WARN AWS_SOLUTIONS_CONSTRUCTS_WARNING: Ignoring enableEncryptionWithCustomerManagedKey because one of topicProps.masterKey, encryptionKey, or encryptionKeyProps was already specified
WARN AWS_SOLUTIONS_CONSTRUCTS_WARNING: Ignoring enableEncryptionWithCustomerManagedKey because one of
WARN AWS_SOLUTIONS_CONSTRUCTS_WARNING: queueProps.encryptionMasterKey, encryptionKey, or encryptionKeyProps was already specified
[Warning at /MyStack/SnsToSqsPattern/queue] encryption: Automatically changed to QueueEncryption.KMS, was: QueueEncryption.KMS_MANAGED
When encryptionMasterKey is provided, always set encryption: QueueEncryption.KMS [ack: @aws-cdk/aws-sqs:queueEncryptionChangedToKMS]

Environment

  • CDK CLI Version : 2.140.0 (build 46168aa)
  • CDK Framework Version: 2.140.0 (build 46168aa)
  • AWS Solutions Constructs Version : 2.57.0
  • OS : MacOS
  • Language : Typescript

Other


This is 🐛 Bug Report

@revanshine revanshine added bug Something isn't working needs-triage The issue or PR still needs to be triaged labels May 8, 2024
@revanshine
Copy link
Author

Also, the minimal deployable pattern won't deploy:

Circular dependency between resources: [SnsToSqsPatternqueueFBC4436B, SnsToSqsPatternqueueMyStackSnsToSqsPatternSnsTopic372915C855A347C7, SnsToSqsPatternSnsTopic4E90E51B, SnsToSqsPatternKeyE8ABAEAE, SnsToSqsPatternqueuePolicy56BD807B, SnsToSqsPatternSnsTopicPolicyA2F69F7F]

Please fix.

@biffgaut
Copy link
Contributor

biffgaut commented May 9, 2024

Thanks, we'll check it out.

@biffgaut
Copy link
Contributor

biffgaut commented May 9, 2024

We're still looking into this, but we have found that the circular reference was introduced with a feature change in CDK v2.32.0 and is controlled by a feature flag. For the moment, you can turn off this change by setting the feature flag to false in cdk.json:

    "@aws-cdk/aws-sns-subscriptions:restrictSqsDescryption": false,

That will allow you to move forward while we continue to examine the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs-triage The issue or PR still needs to be triaged
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants