Members with the @httpQuery
trait are mishandled in responses and response tests
#1500
Labels
bug
This issue is a bug.
Describe the bug
When a response includes a member with the
@httpQuery
trait, that trait is to be ignored and the value for that member is to be read from the response.Instead, the member is set to
nil
and is excluded from equality checks during protocol response tests.As a result, tests such as this one pass even though the logic being tested is incorrect in smithy-swift:
https://github.com/smithy-lang/smithy/blob/ae319f42ebd611d6564a9715089931905acbf315/smithy-aws-protocol-tests/model/restXml/http-query.smithy#L362
Expected Behavior
The test linked above should pass after checking all members of the response for equality.
Current Behavior
The linked test passes, but only because the member marked with the
@httpQuery
trait is not tested for equality.Reproduction Steps
.filter { ... }
statement here, which excludes members marked with the@httpQuery
trait from equality evaluation when comparing results of a response protocol test.Possible Solution
No response
Additional Information/Context
No response
AWS SWIFT SDK version used
main
Compiler and Version used
Xcode 15.4
Operating System and version
macOS 14.4.1
The text was updated successfully, but these errors were encountered: