Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move event streaming code to smithy-swift #1456

Closed
2 tasks
jbelkins opened this issue Apr 24, 2024 · 1 comment
Closed
2 tasks

Move event streaming code to smithy-swift #1456

jbelkins opened this issue Apr 24, 2024 · 1 comment
Assignees
Labels
feature-request A feature should be added or improved.

Comments

@jbelkins
Copy link
Contributor

Describe the feature

Some event streaming code (i.e. for marshalling & unmarshalling event stream types) is located in aws-sdk-swift, even though event streaming is a core Smithy feature.

Locate non-AWS specific event streaming code that is in aws-sdk-swift & move it to smithy-swift. Also, add an event streaming operation to the Test SDK to verify that smithy-swift can build an SDK with event streams.

Use Case

To support core Smithy features in smithy-swift and properly modularize the SDK

Proposed Solution

Move types & break dependencies as needed.

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change
@jbelkins jbelkins added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Apr 24, 2024
@jbelkins jbelkins self-assigned this Apr 24, 2024
@dayaffe dayaffe removed the needs-triage This issue or PR still needs to be triaged. label Apr 29, 2024
@jbelkins
Copy link
Contributor Author

Event streaming code has been modularized per standard ref. architecture. This included moving code out of SDK and into modules provided by smithy-swift.

Closing since this is already tracked by #1384 and #1385.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request A feature should be added or improved.
Projects
None yet
Development

No branches or pull requests

2 participants