Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS Route 53 InvalidBatchError customization does not work #1447

Open
jbelkins opened this issue Apr 21, 2024 · 0 comments
Open

AWS Route 53 InvalidBatchError customization does not work #1447

jbelkins opened this issue Apr 21, 2024 · 0 comments
Assignees
Labels
bug This issue is a bug. needs-investigation

Comments

@jbelkins
Copy link
Contributor

Describe the bug

There is a customization in place to accommodate a difference between the published format of the InvalidBatchError operation error and the format actually returned by Route 53, i.e.:
https://github.com/awslabs/aws-sdk-swift/blob/main/codegen/smithy-aws-swift-codegen/src/main/kotlin/software/amazon/smithy/aws/swift/codegen/customization/route53/Route53InvalidBatchErrorIntegration.kt

However, this customization does not actually deserialize the data returned by Route 53 when an InvalidBatchError occurs.

Expected Behavior

The InvalidBatchError should be populated by error messages for the one or more errors that occur in a Route 53 batch update operation.

Current Behavior

The Message and Messages fields in an InvalidBatchError are both empty.

Reproduction Steps

Take the Route 53 integration test in this PR, and modify it to create an A record not in the hosted domain.
#1445

Run the test.

Possible Solution

No response

Additional Information/Context

No response

AWS SWIFT SDK version used

main

Compiler and Version used

Xcode 15.3

Operating System and version

macOS 14

@jbelkins jbelkins added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Apr 21, 2024
@jbelkins jbelkins self-assigned this Apr 21, 2024
@sichanyoo sichanyoo reopened this Apr 22, 2024
@sichanyoo sichanyoo added needs-investigation and removed needs-triage This issue or PR still needs to be triaged. labels Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug. needs-investigation
Projects
None yet
Development

No branches or pull requests

2 participants