Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replay Util: In current logic COPY replacements will always yield 0 replacements #589

Open
iftachsc opened this issue Dec 12, 2021 · 0 comments

Comments

@iftachsc
Copy link

in the first iteration of our tests to replay copy statements we saw that all copy statements were executed and failed.
when looking into the logs we see the the logs yilded/parsed 0 statements based on this code.
"Loaded {len(copy_replacements)} COPY replacements from {replacements_path}"

looking into the code it seems that this will always be the case because in the extract phase the csv file copy_replacements.csv is built from the file locations of the orioginal files - which in our case was not the case because we replayed the workloads in a different aws account and copied the files used by the copy commands from the original account (like the aws blog says) - and then the replay part makes condition on the next 2 cells (destination file, replacement iam role) so it always will find 0.

the only thing we needed to do to overcome this is to quickly after the replay part generates the replacements file - to inject instead our own corrected file with the new destination files and replacement iam rolw.

@iftachsc iftachsc changed the title In current logic COPY replacements will always yield 0 replacement Replay Util: In current logic COPY replacements will always yield 0 replacement Dec 12, 2021
@iftachsc iftachsc changed the title Replay Util: In current logic COPY replacements will always yield 0 replacement Replay Util: In current logic COPY replacements will always yield 0 replacements Dec 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant