Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Registering buffers in Components #236

Open
prabhuteja12 opened this issue May 17, 2023 · 0 comments
Open

Registering buffers in Components #236

prabhuteja12 opened this issue May 17, 2023 · 0 comments
Labels

Comments

@prabhuteja12
Copy link
Contributor

The Component class implements a _register_parameters method that registers the loss' constructor arguments.

This currently works without glitches where Renate manages the state_dict of Learner, Model and others. However, once the move to relying on Lightning for all checkpointing is complete (in #218) this fails as registering the constructor args (say _weight) returns it in the state_dict, and causes an error when restoring the model from checkpoint. The 'fix' for now is going to by changing RenateModule's load_state_dict to use strict=False.

This issue should help cleanup the components code too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant