Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize usage of batch_size #212

Open
lballes opened this issue May 3, 2023 · 0 comments
Open

Standardize usage of batch_size #212

lballes opened this issue May 3, 2023 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@lballes
Copy link
Contributor

lballes commented May 3, 2023

Currently, our ER-based methods use a batch that consists of batch_size points from the current task and memory_batch_size points from the memory. This is inconvenient to compare/standardize to some other learners (e.g., Joint, GDumb, Fine-tuning) and will also result in a smaller total batch size in the first training stage (when no memory exists).

I propose that all methods use batches of size batch_size. ER-based methods can have an additional argument called memory_frac that determines which fraction of the batch will be filled with points from the memory.

@lballes lballes added the triage label May 3, 2023
@lballes lballes self-assigned this May 5, 2023
@lballes lballes added enhancement New feature or request and removed triage labels May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant