Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashes in reference parse_by_updater #206

Open
alexanderbuchholz opened this issue Apr 27, 2023 · 1 comment
Open

Dashes in reference parse_by_updater #206

alexanderbuchholz opened this issue Apr 27, 2023 · 1 comment

Comments

@alexanderbuchholz
Copy link

alexanderbuchholz commented Apr 27, 2023

Hello,
I spotted some inconsistency in how you define class names and how you reference them in the parsing.
For example in

"Offline-ER": _add_offline_er_arguments,

you are using "Offline-ER" with a dash whereas the class name is camel case in
class OfflineExperienceReplayLearner(ReplayLearner):

Would it be possible to unify the parsed names? For example if I want to run a job using the run_training_job function I was not sure how to set the updater in

.
Thanks and great library!

@wistuba
Copy link
Contributor

wistuba commented Apr 27, 2023

Hey!
The mapping you are looking for is documented here: https://renate.readthedocs.io/en/latest/getting_started/supported_algorithms.html

Regarding changing these names: Do you have already a deterministic mapping from class name to updater indicator in mind?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants