Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow model_fn to get more arguments #65

Open
ehsanmok opened this issue Aug 6, 2020 · 2 comments
Open

Allow model_fn to get more arguments #65

ehsanmok opened this issue Aug 6, 2020 · 2 comments

Comments

@ehsanmok
Copy link

ehsanmok commented Aug 6, 2020

Right now, model_fn only accepts model_dir which is very limiting in case a model needs some arguments to be instantiated first then can load the checkpoint.

@ehsanmok
Copy link
Author

Any update on this issue?

This is limiting as when a user wants to pass different hyperparameters, they must be hardcoded inside the model_fn.

@zachchurchill
Copy link

I agree that the single model_dir argument is pretty restricting. One way I've gotten around hardcoding specific values is by using environment variables to pass in parameters that can be used in the model_fn at runtime, e.g. which model file to use during a Batch Transform job if I happen to load several models in with my model artifact.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants