Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RequestPayer property in CopyPartRequest class. #3081

Closed
ashishdhingra opened this issue Oct 26, 2023 · 12 comments
Closed

Add RequestPayer property in CopyPartRequest class. #3081

ashishdhingra opened this issue Oct 26, 2023 · 12 comments
Labels
bug This issue is a bug. p1 This is a high priority issue queued s3

Comments

@ashishdhingra
Copy link
Contributor

Describe the bug

Reference issue: #3068.

RequestPayer property is missing from from CopyPartRequest class. Java code allows setting x-amz-request-payer header by executing .withRequesterPays(true) statement on CopyPartRequest object. There is no such supported property in .NET SDK's CopyPartRequest. Most of the code in .NET S3 version is hand crafted, so there is high probability that this property was somehow missed during implementation (even though S3 service model specifies this property).

Expected Behavior

CopyPartRequest class has RequestPayer property. Corresponding marshaller should set x-amz-request-payer header, perhaps the same way as done in

.

Current Behavior

CopyPartRequest class doesn't have RequestPayer property.

Reproduction Steps

Refer issue #3068.

Possible Solution

No response

Additional Information/Context

No response

AWS .NET SDK and/or Package version used

AWS SDK for .NET 3.7.9.17

Targeted .NET Platform

.NET Core 3.1

Operating System and version

Windows

@ashishdhingra ashishdhingra added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. p1 This is a high priority issue s3 needs-review and removed needs-triage This issue or PR still needs to be triaged. labels Oct 26, 2023
@krishsingh-git
Copy link

Please update ,, this is a blocker

@ashishdhingra
Copy link
Contributor Author

ashishdhingra commented Nov 2, 2023

Please update ,, this is a blocker

@krishsingh-git The fix is queued in staging branch and would be released today. Kindly wait.

@krishsingh-git
Copy link

Please make sure , release NuGet package also for latest version

@ashishdhingra
Copy link
Contributor Author

Please make sure , release NuGet package also for latest version

That’s the normal process we follow. NuGet package version would be bumped up.

@krishsingh-git
Copy link

Thanks for support

@ashishdhingra
Copy link
Contributor Author

The fix has been released in AWSSDK.S3 version 3.7.205.22.

Copy link

github-actions bot commented Nov 2, 2023

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

@krishsingh-git
Copy link

DownloadObjectToFilePathAsync also had same erro access denied due to requestpayer bucket

@ashishdhingra
Copy link
Contributor Author

DownloadObjectToFilePathAsync also had same erro access denied due to requestpayer bucket

@krishsingh-git Could you please open a new GitHub issue which could be reviewed by the team.

@krishsingh-git
Copy link

krishsingh-git commented Apr 25, 2024 via email

@krishsingh-git
Copy link

krishsingh-git commented Apr 25, 2024 via email

@krishsingh-git
Copy link

krishsingh-git commented Apr 25, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug. p1 This is a high priority issue queued s3
Projects
None yet
Development

No branches or pull requests

2 participants