Are GeneratePreSignedUrlTests wrong due to Expires?

[wlandgraf]

I wonder if tests at GEneratePreSigendUrlTests.cs are wrong?
In most (if not all) tests, the Expiration parameter is set as UTC, for example:

            TestPreSignedUrl(new PresignedUrlTestParameters
            {
                Region = RegionEndpoint.USEast1,
                Expiration = AWSSDKUtils.CorrectedUtcNow.AddDays(7).AddHours(-2),
                UseSigV4 = true,
                ExpectSigV4Url = true,
                IsS3Express = false
            });

However, it's used to set the Expires property of the GetPresignedUrlRequest:

            var request = new GetPreSignedUrlRequest
            {
                BucketName = testParams.BucketName,
                Key = objectKey,
                Verb = HttpVerb.PUT,
                Expires = testParams.Expiration,
                Protocol = Protocol.HTTPS
            };

Which is expected to be in local time.
I wonder if the tests passed so far because you are running in a machine which time zone is UTC?

[dscpinheiro]

These tests run before every release, so we'd have noticed if they were failing (for the record: they do run in hosts with the timezone set to UTC).

Were you trying to run them locally and seeing failures?

[wlandgraf]

No, I didn't run the tests, but I was doing tests with similar code in separate application and I noticed it's wrong.

for the record: they do run in hosts with the timezone set to UTC

That explains why the tests are passing, right?

[dscpinheiro]

I wouldn't call them wrong, they were written expecting to be run in UTC...

If you find an issue with the GetPreSignedUrl API, feel free to open a new issue.

[wlandgraf]

No problem. I just wanted to clarify what I found. Thank you.

[github-actions[bot]]

Hello! Reopening this discussion to make it searchable.