Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracing miss span context with transfer manager or thread executor #2732

Open
1 of 2 tasks
lyrq opened this issue Oct 27, 2023 · 1 comment
Open
1 of 2 tasks

Tracing miss span context with transfer manager or thread executor #2732

lyrq opened this issue Oct 27, 2023 · 1 comment
Labels
feature-request A feature should be added or improved. p3 This is a minor priority issue

Comments

@lyrq
Copy link

lyrq commented Oct 27, 2023

Describe the feature

Current implementation of tracing creates a span context from opentelemetry::context::RuntimeContext::GetCurrent()
This is a thread_local stack of previous span context.

When getting an object through the transfer manager or with GetObjectCallable or GetObjectAsync the span will be created from another thread than the one doing the request.
There is no way to link or give the right parent to the span created in S3Client::GetObject.

Could you provide a way to propagate the right context like opentelemetry propagator is doing between client / server with http headers?

Use Case

I can't correlate smithy tracing span in S3Client GetObject with my code
Exemple:

             main thread                                                   thread executor
| Span A |(application)
   | Span B | (TransferManager::DownloadFile)
                 | Span D | (Proccess Data)                           | Span C | (GetObject)

Proposed Solution

No response

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change
@lyrq lyrq added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Oct 27, 2023
@jmklix
Copy link
Member

jmklix commented Oct 30, 2023

Thanks for using this sdk and taking the time to open this feature request. We do want to add support for this, but this is not a high priority currently. I will make sure to update here when we add support

@jmklix jmklix added p3 This is a minor priority issue and removed needs-triage This issue or PR still needs to be triaged. labels Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request A feature should be added or improved. p3 This is a minor priority issue
Projects
None yet
Development

No branches or pull requests

2 participants