Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ASP.NET Core 3.0 with Amazon.Lambda.AspNetCoreServer #481

Closed
normj opened this issue Jun 25, 2019 · 12 comments
Closed

Support ASP.NET Core 3.0 with Amazon.Lambda.AspNetCoreServer #481

normj opened this issue Jun 25, 2019 · 12 comments
Labels
feature-request A feature should be added or improved.

Comments

@normj
Copy link
Member

normj commented Jun 25, 2019

With the .NET Core custom runtime support it is possible to use .NET Core 3.0 for Lambda functions.

ASP.NET Core 3.0 has some breaking changes that require an additional version of Amazon.Lambda.AspNetCoreServer to be created.

The changes have been made in aspnetcore30-support branch. Unfortunately to build the package with our current build infrastructure we would have to install a preview version of .NET Core in our build environment to build production packages which cannot do. Assuming no more significant changes happen to ASP.NET Core 3.0 before GA these changes will go out with the main package when .NET Core 3.0 goes GA.

For those that want to test a preview version you can checkout my samples repo. In the nuget-cache directory is a prebuilt preview version of Amazon.Lambda.AspNetCoreServer.

@arnd27
Copy link
Contributor

arnd27 commented Aug 3, 2019

With the last update to 3.0.100-preview7-012821, HostingApplication and Context class in namespace "Microsoft.AspNetCore.Hosting" not public anymore!

@normj
Copy link
Member Author

normj commented Aug 5, 2019

Thanks for bringing this to my attention. I'll look to see what we need to do to adapt to .NET Core 3.0.

@normj
Copy link
Member Author

normj commented Aug 19, 2019

The sample has been updated to support .NET Core 3.0 preview 8. Here is the PR that I plan on merging after .NET Core 3.0 is released that contains the changes to Amazon.Lambda.AspNetCoreServer. #508

This PR contains breaking changes even for .NET Core 2.1 users. The changes are slight and should only affect users that customized the serialization between API Gateway and ASP.NET Core but I would appreciate feedback on the changes. The list of breaking changes are listed in the PR.

@andymac4182
Copy link

Great news! I will be deploying a service shortly on Preview 8 I was waiting for the fix before I did it :)

@normj
Copy link
Member Author

normj commented Sep 19, 2019

I pushed some changes in for the upcoming version of Amazon.Lambda.AspNetCoreServer that will support .NET Core 3.0 with Custom Lambda Runtimes. Most notably implementing the required method to send static files from the ASP.NET Core application. I have updated the samples repo with version 4.0.0-preview2 of Amazon.Lambda.AspNetCoreServer in the nuget-cache folder. I would appreciate feedback on this version.

@martonx
Copy link

martonx commented Sep 24, 2019

Hi,

When will be the .Net Core 3 support official?

@normj
Copy link
Member Author

normj commented Sep 25, 2019

To be clear .NET Core 3.0 will not be an officially supported runtime in Lambda since it is not an LTS. You can use .NET Core 3.0 with our Custom Runtime feature.

I'm working on updating our build infrastructure that pushes out to NuGet to have .NET Core 3.0 on it so I can push this new version of Amazon.Lambda.AspNetCoreServer. That will allow users using custom runtimes to also do it with ASP.NET Core 3.0 Lambda functions.

@bmiller-0
Copy link

.NET Core 3.1 will be LTS when released in November, according to Microsoft How soon after that release should we expect to see the support in Lambda?

@normj
Copy link
Member Author

normj commented Sep 27, 2019

Sorry I can't talk about schedule as there are always so many variables to getting things out I don't want anybody depending on anything I say.

@bmiller-0
Copy link

Makes sense. I guess I should have asked a bit more generally to verify that since 3.1 will be LTS that we should expect to see it supported natively in Lambda at some point in the future.

@normj
Copy link
Member Author

normj commented Oct 26, 2019

Version 4.0.0 of Amazon.Lambda.AspNetCoreServer has shipped with support for .NET Core 3.0

@alexAlchemy
Copy link

https://devblogs.microsoft.com/dotnet/announcing-net-core-3-1/

LTS Version released a whole 17 hours ago.... is it officially supported yet? ;-)

#Earlyxmas

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request A feature should be added or improved.
Projects
None yet
Development

No branches or pull requests

6 participants