Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use SourceGeneratorLambdaJsonSerializer for AspNetCoreServer functions #1720

Open
1 of 2 tasks
Dreamescaper opened this issue Apr 9, 2024 · 1 comment
Open
1 of 2 tasks

Use SourceGeneratorLambdaJsonSerializer for AspNetCoreServer functions #1720

Dreamescaper opened this issue Apr 9, 2024 · 1 comment
Labels
feature-request A feature should be added or improved. module/aspnetcore-support p2 This is a standard priority issue queued

Comments

@Dreamescaper
Copy link
Contributor

Dreamescaper commented Apr 9, 2024 •
edited

Describe the feature

Currently reflection-based DefaultLambdaJsonSerializer is used for AspNetCore functions. But since we know for sure which types (HttpApi/RestApi/LoadBalancer) are going to be used there, probably it makes sense to use source-generated SourceGeneratorLambdaJsonSerializer.

Use Case

Improved performance (especially cold-start) and better AOT compatibility.

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change
@Dreamescaper Dreamescaper added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Apr 9, 2024
@ashishdhingra
Copy link
Contributor

Needs review with the team.

@ashishdhingra ashishdhingra added needs-review p2 This is a standard priority issue queued and removed needs-triage This issue or PR still needs to be triaged. needs-review labels Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature-request A feature should be added or improved. module/aspnetcore-support p2 This is a standard priority issue queued
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Dreamescaper @ashishdhingra