Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundled installer errors out when the install path has a space #977

Closed
jamesls opened this issue Oct 28, 2014 · 2 comments
Closed

Bundled installer errors out when the install path has a space #977

jamesls opened this issue Oct 28, 2014 · 2 comments
Labels
blocked Work is blocked on this issue for this codebase. Other labels or comments may indicate why. bug This issue is a bug. closing-soon This issue will automatically close in 4 days unless further comments are made.

Comments

@jamesls
Copy link
Member

jamesls commented Oct 28, 2014

Specifying -i/ --install-dir with a path containing a space will error out.

@jamesls jamesls added bug This issue is a bug. accepted labels Oct 28, 2014
@jamesls
Copy link
Member Author

jamesls commented Oct 28, 2014

Some additional notes, even after fixing our invocations of Popen to properly handle spaces, it looks like we're now running into pypa/virtualenv#53

Will likely need to investigate workarounds until this issue is fixed.

@jamesls jamesls added the blocked Work is blocked on this issue for this codebase. Other labels or comments may indicate why. label Feb 10, 2015
@jamesls
Copy link
Member Author

jamesls commented Apr 25, 2016

I'm inclined to close this. Reading the linked issue in virtualenv, it seems like this is a fundamental issue that you just can't have spaces in the #! line. Given that's not going to be fixed, and that we've documented this limitation in our install guide (http://docs.aws.amazon.com/cli/latest/userguide/installing.html#install-bundle-other), I think we've done all we can for this issue.

@jamesls jamesls added the closing-soon This issue will automatically close in 4 days unless further comments are made. label Apr 25, 2016
@jamesls jamesls closed this as completed Jun 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Work is blocked on this issue for this codebase. Other labels or comments may indicate why. bug This issue is a bug. closing-soon This issue will automatically close in 4 days unless further comments are made.
Projects
None yet
Development

No branches or pull requests

1 participant