Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ECR get-login produces an invalid parameter for ECR get-login #3881

Closed
combusean opened this issue Jan 22, 2019 · 4 comments
Closed

ECR get-login produces an invalid parameter for ECR get-login #3881

combusean opened this issue Jan 22, 2019 · 4 comments
Assignees
Labels
closing-soon This issue will automatically close in 4 days unless further comments are made. guidance Question that needs advice or information.

Comments

@combusean
Copy link

combusean commented Jan 22, 2019

I noticed this standard behavior using the aws ECR cli and found it unusual.

Anything I'm missing in this? This seems widespread.

$ aws ecr get-login
docker login -u AWS -p eyJw....= -e none https://....ecr.us-west-2.amazonaws.com

$(aws ecr get-login)
unknown shorthand flag: 'e' in -e
See 'docker login --help'.

Leaving out the -e in the docker command fixes this.

@combusean
Copy link
Author

$ aws --version
aws-cli/1.16.55 Python/3.7.1 Darwin/18.0.0 botocore/1.12.45

@justnance justnance self-assigned this Jan 22, 2019
@mnahkies
Copy link

See pull request #1922 - effectively the solution seems to be adding the --no-include-email parameter

@justnance justnance added the guidance Question that needs advice or information. label Jan 24, 2019
@justnance
Copy link

@combusean - Thanks for reaching out. The '-e' option has been deprecated and is removed in docker version 17.06 and later. You must specify --no-include-email if you're using docker version 17.06 or later. The default behavior is to include the '-e' flag in the 'docker login' output. Basically, using the --no-include-email option will remove the -e flag from the output. Currently we are we are keeping the -e for backwards compatibility reasons as users may be using an old version of docker that still uses it.

Reference: #3669 and #3374

@justnance justnance added the closing-soon This issue will automatically close in 4 days unless further comments are made. label Jan 24, 2019
@no-response
Copy link

no-response bot commented Jan 31, 2019

This issue has been automatically closed because there has been no response to our request for more information from the original author. With only the information that is currently in the issue, we don't have enough information to take action. Please reach out if you have or find the answers we need so that we can investigate further.

@no-response no-response bot closed this as completed Jan 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closing-soon This issue will automatically close in 4 days unless further comments are made. guidance Question that needs advice or information.
Projects
None yet
Development

No branches or pull requests

3 participants