Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ec2): create NAT Gateways with fixed IPs #14250

Merged
merged 5 commits into from Apr 21, 2021
Merged

feat(ec2): create NAT Gateways with fixed IPs #14250

merged 5 commits into from Apr 21, 2021

Conversation

rix0rrr
Copy link
Contributor

@rix0rrr rix0rrr commented Apr 19, 2021

Select static IPs for NAT gateways by pre-creating EIP allocations and
passing them into the NAT gateway provider.

Fixes #11884, fixes #4067.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@rix0rrr
feat(ec2): create NAT Gateways with fixed IPs
1db070d 
Select static IPs for NAT gateways by pre-creating EIP allocations and
passing them into the NAT gateway provider.

Fixes #11884, fixes #4067.
@rix0rrr rix0rrr requested a review from a team April 19, 2021 09:41
@rix0rrr rix0rrr self-assigned this Apr 19, 2021
@gitpod-io
Copy link

gitpod-io bot commented Apr 19, 2021 •
edited

@github-actions github-actions bot added the @aws-cdk/aws-ec2 Related to Amazon Elastic Compute Cloud label Apr 19, 2021
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Apr 19, 2021
@rix0rrr rix0rrr added the pr-linter/exempt-readme The PR linter will not require README changes label Apr 19, 2021
nija-at
nija-at suggested changes Apr 19, 2021
View reviewed changes
packages/@aws-cdk/aws-ec2/lib/nat.ts Outdated
/**
* Properties for a NAT gateway
*
* @experimental
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this is being banned. I believe, you have to either go with the new model of 'Pre' suffix or just take this as a stable API.

cc @NetaNir

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The APIs above and below also had @experimental still there, so seeing as no code change has been made here yet, I'd like to keep this in line with the rest.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

coordinate with @NetaNir on this. See #14071.

Copy link
Contributor

@NetaNir NetaNir Apr 21, 2021 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nija-at is right, we removed all @expiremental annotations and added a lint rule to disallow the use of this annotation. The PR for the removal was merged today, I was keeping it open to allow owners to make any adjustments before all APIs are marked as stable.

I pushed the change to remove the @experimetnal flag to your branch and merged in the latest changes from master.

If you want to keep this API non-final, you can add a preview suffix to both the method and the props. The preview API spec is not yet written but we had some discussion on this PR, in which it was decided to use the suffix beta1.

packages/@aws-cdk/aws-ec2/lib/nat.ts Show resolved Hide resolved
@rix0rrr rix0rrr requested review from nija-at and NetaNir April 19, 2021 16:02
@nija-at nija-at added the pr/requires-two-approvers This PR is critical (e.g., security, broadly-impacting) and requires 2 approvers to be merged. label Apr 19, 2021
nija-at
nija-at approved these changes Apr 19, 2021
View reviewed changes
Copy link
Contributor

@nija-at nija-at left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added label for second approver. Check with Neta on the experimental annotation.

Rest of the code LGTM.

@rix0rrr rix0rrr removed the pr/requires-two-approvers This PR is critical (e.g., security, broadly-impacting) and requires 2 approvers to be merged. label Apr 21, 2021
@mergify
Copy link
Contributor

mergify bot commented Apr 21, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 423deaf
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Apr 21, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 24c992a into master Apr 21, 2021
@mergify mergify bot deleted the huijbers/nat-gateway-alloc-ids branch April 21, 2021 14:44
john-tipper pushed a commit to john-tipper/aws-cdk that referenced this pull request May 10, 2021
@rix0rrr @john-tipper
feat(ec2): create NAT Gateways with fixed IPs (aws#14250)
d8d93e2 
Select static IPs for NAT gateways by pre-creating EIP allocations and
passing them into the NAT gateway provider.

Fixes aws#11884, fixes aws#4067.


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@whoami-defnotme whoami-defnotme mentioned this pull request Aug 13, 2021
Closed
5 tasks
hollanddd pushed a commit to hollanddd/aws-cdk that referenced this pull request Aug 26, 2021
@rix0rrr @hollanddd
feat(ec2): create NAT Gateways with fixed IPs (aws#14250)
a60c95f 
Select static IPs for NAT gateways by pre-creating EIP allocations and
passing them into the NAT gateway provider.

Fixes aws#11884, fixes aws#4067.


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nija-at nija-at nija-at approved these changes

@NetaNir NetaNir Awaiting requested review from NetaNir

Assignees

@rix0rrr rix0rrr

Labels
@aws-cdk/aws-ec2 Related to Amazon Elastic Compute Cloud contribution/core This is a PR that came from AWS. pr-linter/exempt-readme The PR linter will not require README changes
Projects
None yet
Milestone
No milestone
4 participants
@rix0rrr @aws-cdk-automation @NetaNir @nija-at