feat(globalaccelerator): stabilize AWS Global Accelerator module #13843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: the automatic name of the `Accelerator` construct has changed; explicitly pass an `acceleratorName` property if you need your accelerator to not be replaced.
|
|
github-actions
bot
added
the
@aws-cdk/aws-globalaccelerator
nija-at
approved these changes
Mar 29, 2021
| @@ -0,0 +1,18 @@ | |||
| # Event Targets for Amazon EventBridge | |||
| user traffic coming in on the Listener is ultimately sent. The Endpoint port | ||
| used is the same as the traffic came in on at the Listener, unless overridden. | ||
|
|
||
| ## Types of Endpoints |
There was a problem hiding this comment.
Curious: Why you've chosen this way, instead of a brief summary here and then documenting the actual list in the endpoints package?
There was a problem hiding this comment.
Yeah, it wasn't an easy choice. Ultimately I decided that looking in 1 place is better for users than forcing them to look in 2 places, and the list wasn't impressive enough that we'd gain clarity from splitting it up.
There was a problem hiding this comment.
Sounds good.
I was curious because I've done the opposite with APIGWv2.
|
Obviously, I've not gone through all of the code. just the configuration and skimmed through the README. I trust 'ya. |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
hollanddd
pushed a commit
to hollanddd/aws-cdk
that referenced
this pull request
Mar 31, 2021
…#13843) There are a number of changes to this module, made in order to stabilize it. The changes are as follows: * Endpoints as constructs would only work in TypeScript; they have been moved out as integration classes into `aws-globalaccelerator-endpoints` in order to support languages like Java and C#. * The automatic naming algorithm has been changed to reduce chances of conflict. * There are now convenience methods, `addListener()` and `addEndpointGroup()` that will create the appropriate objects, as alternatives to `new Listener()` and `new EndpointGroup()`. * EndpointGroups can take a list of `endpoints` in the constructor. * A Listener's `toPort` is optional (and defaults to `fromPort` if not supplied). * Support all the EndpointGroup properties. * An EndpointGroup's `region` is automatically determined from its configured endpoints, if possible. * The looked-up SecurityGroup is no longer accessible as a full Security Group, it can just be reference as a Peer (modifying the rules is not recommended by AGA and should not be allowed from the CDK). Changes to other libraries made to support this: * core, elbv2: imported Load Balancers now are aware of the region and account they were actually imported from, in order to be able to make `region` implicit in the AGA API. BREAKING CHANGE: automatic naming algorithm has been changed: if you have existing Accelerators you will need to pass an explicit name to prevent them from being replaced. All endpoints are now added by calling `addEndpoint()` with a target-specific class that can be found in `@aws-cdk/aws-globalaccelerator-endpoints`. The generated Security Group is now looked up by calling `endpointGroup.connectionsPeer()`. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
hollanddd
pushed a commit
to hollanddd/aws-cdk
that referenced
this pull request
Aug 26, 2021
…#13843) There are a number of changes to this module, made in order to stabilize it. The changes are as follows: * Endpoints as constructs would only work in TypeScript; they have been moved out as integration classes into `aws-globalaccelerator-endpoints` in order to support languages like Java and C#. * The automatic naming algorithm has been changed to reduce chances of conflict. * There are now convenience methods, `addListener()` and `addEndpointGroup()` that will create the appropriate objects, as alternatives to `new Listener()` and `new EndpointGroup()`. * EndpointGroups can take a list of `endpoints` in the constructor. * A Listener's `toPort` is optional (and defaults to `fromPort` if not supplied). * Support all the EndpointGroup properties. * An EndpointGroup's `region` is automatically determined from its configured endpoints, if possible. * The looked-up SecurityGroup is no longer accessible as a full Security Group, it can just be reference as a Peer (modifying the rules is not recommended by AGA and should not be allowed from the CDK). Changes to other libraries made to support this: * core, elbv2: imported Load Balancers now are aware of the region and account they were actually imported from, in order to be able to make `region` implicit in the AGA API. BREAKING CHANGE: automatic naming algorithm has been changed: if you have existing Accelerators you will need to pass an explicit name to prevent them from being replaced. All endpoints are now added by calling `addEndpoint()` with a target-specific class that can be found in `@aws-cdk/aws-globalaccelerator-endpoints`. The generated Security Group is now looked up by calling `endpointGroup.connectionsPeer()`. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a number of changes to this module, made in order to stabilize it. The changes are as follows:
aws-globalaccelerator-endpointsin order to support languages like Java and C#.addListener()andaddEndpointGroup()that will createthe appropriate objects, as alternatives to
new Listener()andnew EndpointGroup().endpointsin the constructor.toPortis optional (and defaults tofromPortif not supplied).regionis automatically determined from its configured endpoints, if possible.be reference as a Peer (modifying the rules is not recommended by AGA and should not be allowed
from the CDK).
Changes to other libraries made to support this:
order to be able to make
regionimplicit in the AGA API.BREAKING CHANGE: automatic naming algorithm has been changed: if you have existing Accelerators you will need to pass an
explicit name to prevent them from being replaced. All endpoints are now added by calling
addEndpoint()with atarget-specific class that can be found in
@aws-cdk/aws-globalaccelerator-endpoints. The generated Security Groupis now looked up by calling
endpointGroup.connectionsPeer().By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license