feat(events): API Gateway target #13823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
added
the
@aws-cdk/aws-apigateway
rix0rrr
previously requested changes
Apr 6, 2021
| * | ||
| * @default - no message group ID (regular queue) | ||
| */ | ||
| readonly messageGroupId?: string; |
There was a problem hiding this comment.
Does this not need to be removed?
There was a problem hiding this comment.
Sorry, this is my mistake.
| * | ||
| * @default the entire EventBridge event | ||
| */ | ||
| readonly message?: events.RuleTargetInput; |
There was a problem hiding this comment.
Does this not need to be removed?
Where DOES the payload go?
There was a problem hiding this comment.
Should this be called something like postBody ?
There was a problem hiding this comment.
You are right. This will send to API as post body. I fixed.
| * | ||
| * @default - no dead-letter queue | ||
| */ | ||
| readonly deadLetterQueue?: sqs.IQueue; |
There was a problem hiding this comment.
Are eventRole and deadletterQueue not inheritable from some common props type?
| httpParameters: { | ||
| headerParameters: this.props?.headerParameters, | ||
| queryStringParameters: this.props?.queryStringParameters, | ||
| pathParameterValues: this.props?.pathParameterValues, |
There was a problem hiding this comment.
Should we not validate pathParameterValues.length agains the number of * in the path ?
There was a problem hiding this comment.
I didn't know if it would be better to validate with CDK or wait for Cloudformation to handle the errors naturally at runtime.
(If it is documented somewhere, I would appreciate it if you could let me know.)
I have implemented validation as you mentioned.
…dd-api-gateway
|
|
rix0rrr
previously approved these changes
Apr 22, 2021
rix0rrr
changed the title
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
rix0rrr
changed the title
github-actions
bot
added
@aws-cdk/aws-apigateway
|
I resolved conflict. |
rix0rrr
approved these changes
Apr 23, 2021
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
mergify bot
pushed a commit
that referenced
this pull request
May 5, 2021
A previous [PR](#13823) added a dependency from the stable module `aws-events-targets` to the experimental module `aws-batch`. Depending on experimental modules is no longer allowed. In fact, this PR build should have failed when attempting to build `aws-cdk-lib`, preventing it from being merged. However, since the dependency was added but not used, the build succeeded, and the PR was merged. ### Why did we expect the PR build of #13823 to fail? In the build step of `aws-cdk-lib` we strip all the L2 of experimental modules. This means that when compiling `aws-cdk-lib` the L2 types of experimental modules does not exists, if a stable module reference such a type, the build of `aws-cdk-lib` will fail. ### Why did the PR build of #13823 succeeded? It added a dependency on the experimental `aws-batch` but didn't use it. ### What are we doing to prevent this from happening in the future? #14249 adds a lint rule that disallow depending on an experimental module. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
john-tipper
pushed a commit
to john-tipper/aws-cdk
that referenced
this pull request
May 10, 2021
close aws#12708 Added construct class of api gateway target . ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
john-tipper
pushed a commit
to john-tipper/aws-cdk
that referenced
this pull request
May 10, 2021
A previous [PR](aws#13823) added a dependency from the stable module `aws-events-targets` to the experimental module `aws-batch`. Depending on experimental modules is no longer allowed. In fact, this PR build should have failed when attempting to build `aws-cdk-lib`, preventing it from being merged. However, since the dependency was added but not used, the build succeeded, and the PR was merged. ### Why did we expect the PR build of aws#13823 to fail? In the build step of `aws-cdk-lib` we strip all the L2 of experimental modules. This means that when compiling `aws-cdk-lib` the L2 types of experimental modules does not exists, if a stable module reference such a type, the build of `aws-cdk-lib` will fail. ### Why did the PR build of aws#13823 succeeded? It added a dependency on the experimental `aws-batch` but didn't use it. ### What are we doing to prevent this from happening in the future? aws#14249 adds a lint rule that disallow depending on an experimental module. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
hollanddd
pushed a commit
to hollanddd/aws-cdk
that referenced
this pull request
Aug 26, 2021
close aws#12708 Added construct class of api gateway target . ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
hollanddd
pushed a commit
to hollanddd/aws-cdk
that referenced
this pull request
Aug 26, 2021
A previous [PR](aws#13823) added a dependency from the stable module `aws-events-targets` to the experimental module `aws-batch`. Depending on experimental modules is no longer allowed. In fact, this PR build should have failed when attempting to build `aws-cdk-lib`, preventing it from being merged. However, since the dependency was added but not used, the build succeeded, and the PR was merged. ### Why did we expect the PR build of aws#13823 to fail? In the build step of `aws-cdk-lib` we strip all the L2 of experimental modules. This means that when compiling `aws-cdk-lib` the L2 types of experimental modules does not exists, if a stable module reference such a type, the build of `aws-cdk-lib` will fail. ### Why did the PR build of aws#13823 succeeded? It added a dependency on the experimental `aws-batch` but didn't use it. ### What are we doing to prevent this from happening in the future? aws#14249 adds a lint rule that disallow depending on an experimental module. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #12708
Added construct class of api gateway target .
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license