Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@aws-cdk/route-53 : Ability to create NS records #13816

Closed
1 of 2 tasks
stijnbrouwers opened this issue Mar 26, 2021 · 4 comments
Closed
1 of 2 tasks

@aws-cdk/route-53 : Ability to create NS records #13816

stijnbrouwers opened this issue Mar 26, 2021 · 4 comments
Assignees
Labels
@aws-cdk/aws-route53 Related to Amazon Route 53 effort/small Small work item – less than a day of effort feature/enhancement A new API to make things easier or more intuitive. A catch-all for general feature requests. feature-request A feature should be added or improved. p2

Comments

@stijnbrouwers
Copy link
Contributor

I would like to be able to create NS records for a hosted zone through CDK.

Use Case

I want to manage all NS records for a hosted zone through CDK.

Proposed Solution

Create a NsRecord in the @aws-cdk/route-53 lib to be able to deploy NS records in the same way as it's currently possible to manage: A records, TXT records, MX records, ...

  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change

This is a 🚀 Feature Request

@stijnbrouwers stijnbrouwers added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Mar 26, 2021
@github-actions github-actions bot added the @aws-cdk/aws-route53 Related to Amazon Route 53 label Mar 26, 2021
@njlynch
Copy link
Contributor

njlynch commented Mar 29, 2021

Hi @stijnbrouwers ,

Thanks for the feature request. You can create NS records through the CDK today, via the route53.RecordSet construct, using the route53.RecordType.NS record type.

However, given that we have L2 constructs specifically for ARecord, TxtRecord, etc., I suppose it makes sense we could create an NSRecord as well. I wouldn't consider this a blocking/top priority, but would be willing to accept a pull request if you're interested in implementing it.

Thanks.

@njlynch njlynch added effort/small Small work item – less than a day of effort p2 and removed needs-triage This issue or PR still needs to be triaged. labels Mar 29, 2021
@stijnbrouwers
Copy link
Contributor Author

Hi @njlynch ,

You can indeed assign the ticket to me, I'll implement it.

Kr

@ericzbeard ericzbeard added the feature/enhancement A new API to make things easier or more intuitive. A catch-all for general feature requests. label Apr 1, 2021
mergify bot pushed a commit that referenced this issue Apr 6, 2021
Adds feature as requested in issue #13816
----
*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@njlynch
Copy link
Contributor

njlynch commented Apr 13, 2021

Closed via #13895

@njlynch njlynch closed this as completed Apr 13, 2021
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

hollanddd pushed a commit to hollanddd/aws-cdk that referenced this issue Aug 26, 2021
Adds feature as requested in issue aws#13816
----
*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-route53 Related to Amazon Route 53 effort/small Small work item – less than a day of effort feature/enhancement A new API to make things easier or more intuitive. A catch-all for general feature requests. feature-request A feature should be added or improved. p2
Projects
None yet
Development

No branches or pull requests

3 participants