Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(codepipeline-actions): introduce the CodeStarConnectionsSourceAction #13781

Merged
merged 1 commit into from Apr 7, 2021

Conversation

skinny85
Copy link
Contributor

At the same time, deprecate the unfortunately-named BitBucketSourceAction.

Fixes #10632


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@skinny85 skinny85 requested a review from NetaNir March 25, 2021 00:52
@gitpod-io
Copy link

gitpod-io bot commented Mar 25, 2021

@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Mar 25, 2021

private readonly props: BitBucketSourceActionProps;
private readonly codeStartConnectionsSourceAction: CodeStarConnectionsSourceAction;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be

  private readonly codeStarConnectionsSourceAction: CodeStarConnectionsSourceAction;

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep! Good eye @nathanyocum-ridgeline 🔎

Copy link
Contributor

@NetaNir NetaNir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked through the code, seems like most of is it introducing the same logic as in BitBucketSourceAction under CodeStarConnectionsSourceAction ? If so, looks good to me. Approving, let me know if you want me to do a more thorough pass

@NetaNir NetaNir added the pr/do-not-merge This PR should not be merged at this time. label Apr 7, 2021
…tion

At the same time, deprecate the unfortunately-named `BitBucketSourceAction`.

Fixes aws#10632
@skinny85 skinny85 force-pushed the chore/deprecate-bitbucket-action branch from 30b7cc1 to 6c75dd2 Compare April 7, 2021 19:42
@skinny85 skinny85 removed the pr/do-not-merge This PR should not be merged at this time. label Apr 7, 2021
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 6c75dd2
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Apr 7, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 8782e67 into aws:master Apr 7, 2021
@skinny85 skinny85 deleted the chore/deprecate-bitbucket-action branch April 7, 2021 20:17
hollanddd pushed a commit to hollanddd/aws-cdk that referenced this pull request Aug 26, 2021
…tion (aws#13781)

At the same time, deprecate the unfortunately-named `BitBucketSourceAction`.

Fixes aws#10632

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[aws-codepipeline-actions] Support for CodeStar Connections in GitHubSourceAction
4 participants