Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(iam): add imported user to a group #13698

Merged
merged 8 commits into from Apr 22, 2021
Merged

feat(iam): add imported user to a group #13698

merged 8 commits into from Apr 22, 2021

Conversation

jogold
Copy link
Contributor

@jogold jogold commented Mar 19, 2021 •
edited

Allow adding an imported user to a group by implementing addToGroup() with
AWS::IAM::UserToGroupAddition.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Mar 19, 2021 •
edited

@github-actions github-actions bot added the @aws-cdk/aws-iam Related to AWS Identity and Access Management label Mar 19, 2021
rix0rrr
rix0rrr previously approved these changes Mar 23, 2021
View reviewed changes
packages/@aws-cdk/aws-iam/lib/user.ts
public addToGroup(_group: IGroup): void {
throw new Error('Cannot add imported User to Group');
public addToGroup(group: IGroup): void {
new CfnUserToGroupAddition(Stack.of(group), `${this.userName}Group${this.groupId}`, {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woooaahhhh

@mergify
Copy link
Contributor

mergify bot commented Mar 23, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot dismissed rix0rrr’s stale review March 23, 2021 14:07

Pull request has been modified.

@jogold
Copy link
Contributor Author

jogold commented Mar 23, 2021

@rix0rrr can you reapprove? Looks like node was missing/not correctly configured in the Docker build image for a short period of time.

/root/ecr-proxy/start.sh: line 28: node: command not found

@jogold
Copy link
Contributor Author

jogold commented Apr 7, 2021

@rix0rrr ping

@mergify
Copy link
Contributor

mergify bot commented Apr 22, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 8e7664d
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Apr 22, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit bf513bc into aws:master Apr 22, 2021
@jogold jogold deleted the iam-imported-user-add-to-group branch April 22, 2021 13:50
john-tipper pushed a commit to john-tipper/aws-cdk that referenced this pull request May 10, 2021
@jogold @john-tipper
feat(iam): add imported user to a group (aws#13698)
92acbaf 
Allow adding an imported user to a group by implementing `addToGroup()` with
[`AWS::IAM::UserToGroupAddition`](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-iam-addusertogroup.html).

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
hollanddd pushed a commit to hollanddd/aws-cdk that referenced this pull request Aug 26, 2021
@jogold @hollanddd
feat(iam): add imported user to a group (aws#13698)
7be1700 
Allow adding an imported user to a group by implementing `addToGroup()` with
[`AWS::IAM::UserToGroupAddition`](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-iam-addusertogroup.html).

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rix0rrr rix0rrr rix0rrr approved these changes

Assignees

@rix0rrr rix0rrr

Labels
@aws-cdk/aws-iam Related to AWS Identity and Access Management
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jogold @aws-cdk-automation @rix0rrr