Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update helm chart #6

Merged
merged 4 commits into from May 13, 2020
Merged

update helm chart #6

merged 4 commits into from May 13, 2020

Conversation

pdk27
Copy link
Contributor

@pdk27 pdk27 commented May 6, 2020

Description of changes:

  • rename helm charts dir
  • modify helm chart and
  • add readme and template/notes.txt
  • add AEMM K8s service support
  • add support for empty env vars

Testing:
Successfully installed AEMM on my K8s cluster via helm (all commands in Readme)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@pdk27 pdk27 requested a review from bwagner5 May 6, 2020 15:53
@pdk27 pdk27 changed the title Helm updates update helm chart May 6, 2020
Copy link
Contributor

@bwagner5 bwagner5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should fix the cluster role thing or just support k8s 1.14+

Copy link
Contributor

@bwagner5 bwagner5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@bwagner5 bwagner5 merged commit 78b8648 into aws:master May 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants