Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for time limited links #345

Open
JanC89 opened this issue Mar 3, 2022 · 5 comments
Open

Support for time limited links #345

JanC89 opened this issue Mar 3, 2022 · 5 comments

Comments

@JanC89
Copy link

JanC89 commented Mar 3, 2022

Describe the feature you'd like
Add support for time limited links. The solution already supports signature validation. So it would be great if you could add an Expires parameter to the URL that will be part of the signing. The Lambda will then simply check the current timestamp against the timestamp specified. If the link has expired return a 403 Forbidden

Our company is very interested in this feature, so we would gladly make an initial PR. We would however like some feedback before we do it, to ensure it is something that fits your pipeline/roadmap.

Thanks!

@fisenkodv
Copy link
Contributor

@JanC89 we will look into it and add it to our backlog. Also, we open for PRs and would gladly review a PR. Thank you for your effort.

@fisenkodv fisenkodv added this to Unassigned in Issues and Roadmap via automation Mar 3, 2022
@github-actions
Copy link

This issue has not received a response in a while. If you want to keep this issue open, please leave a comment below and auto-close will be canceled.

@github-actions
Copy link

github-actions bot commented Sep 8, 2022

This issue was closed because it has been inactive for 7 days since being marked as closing-soon.

@slavoroi
Copy link

This could be an important feature.

@simonkrol
Copy link
Member

Hi @JanC89 and @slavoroi,

Just as an update, we've decided to include this feature in the next minor/major release of SIH, you can see a bit more information on #349.

Thanks for your interest in SIH :)
Simon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

4 participants